-
Notifications
You must be signed in to change notification settings - Fork 9
Allow reuploading discarded vaccinations #4305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MartinVanIJcken
merged 6 commits into
next
from
allow-reuploading-discarded-vaccinations
Aug 19, 2025
Merged
Allow reuploading discarded vaccinations #4305
MartinVanIJcken
merged 6 commits into
next
from
allow-reuploading-discarded-vaccinations
Aug 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
reviewed
Aug 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it possible to add some tests for this as well?
999b81c
to
03cd43a
Compare
thomasleese
reviewed
Aug 18, 2025
7247918
to
6c419bb
Compare
thomasleese
reviewed
Aug 19, 2025
thomasleese
reviewed
Aug 19, 2025
0580e4d
to
b9883ba
Compare
b9883ba
to
b364681
Compare
thomasleese
reviewed
Aug 19, 2025
a7cebac
to
e1c9d7a
Compare
…record Finalize duplicate record page
This fixes the bug where once a vaccination record is discarded, it can never be imported again. Jira-Issue: MAV-1346
Jira-Issue: MAV-1346
e1c9d7a
to
ba92e37
Compare
|
thomasleese
approved these changes
Aug 19, 2025
thomasleese
pushed a commit
that referenced
this pull request
Aug 19, 2025
…nations Allow reuploading discarded vaccinations
thomasleese
pushed a commit
that referenced
this pull request
Aug 20, 2025
…nations Allow reuploading discarded vaccinations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We explicitly set the discarded_at date to nil when uploading a vaccination that duplicates an archived record. When this happens a duplicate is flagged and the user must choose to keep the archived record as archived, or accept the new record non-archived. Jira Issue: MAV-1346