Skip to content

Conversation

MartinVanIJcken
Copy link
Contributor

@MartinVanIJcken MartinVanIJcken commented Aug 18, 2025

We explicitly set the discarded_at date to nil when uploading a vaccination that duplicates an archived record. When this happens a duplicate is flagged and the user must choose to keep the archived record as archived, or accept the new record non-archived. Jira Issue: MAV-1346

@MartinVanIJcken MartinVanIJcken requested review from a team as code owners August 18, 2025 11:09
@MartinVanIJcken MartinVanIJcken changed the base branch from main to next August 18, 2025 11:10
Copy link
Contributor

@thomasleese thomasleese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it possible to add some tests for this as well?

@thomasleese thomasleese added the bug Something isn't working label Aug 18, 2025
@thomasleese thomasleese added this to the v3.2.0 milestone Aug 18, 2025
@MartinVanIJcken MartinVanIJcken force-pushed the allow-reuploading-discarded-vaccinations branch from 999b81c to 03cd43a Compare August 18, 2025 13:45
@MartinVanIJcken MartinVanIJcken force-pushed the allow-reuploading-discarded-vaccinations branch 2 times, most recently from 7247918 to 6c419bb Compare August 18, 2025 15:46
@MartinVanIJcken MartinVanIJcken force-pushed the allow-reuploading-discarded-vaccinations branch 3 times, most recently from 0580e4d to b9883ba Compare August 19, 2025 11:04
@thomasleese thomasleese force-pushed the allow-reuploading-discarded-vaccinations branch from b9883ba to b364681 Compare August 19, 2025 12:21
@MartinVanIJcken MartinVanIJcken force-pushed the allow-reuploading-discarded-vaccinations branch 2 times, most recently from a7cebac to e1c9d7a Compare August 19, 2025 12:46
@MartinVanIJcken MartinVanIJcken force-pushed the allow-reuploading-discarded-vaccinations branch from e1c9d7a to ba92e37 Compare August 19, 2025 13:01
Copy link

@MartinVanIJcken MartinVanIJcken merged commit ed6f432 into next Aug 19, 2025
13 checks passed
@MartinVanIJcken MartinVanIJcken deleted the allow-reuploading-discarded-vaccinations branch August 19, 2025 13:33
thomasleese pushed a commit that referenced this pull request Aug 19, 2025
…nations

Allow reuploading discarded vaccinations
thomasleese pushed a commit that referenced this pull request Aug 20, 2025
…nations

Allow reuploading discarded vaccinations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants