Fix flaky consent matching test #4318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously searching for patients based on their first name, which in most cases will return a response, but if the randomly generated first name is a lot shorter than the last name then the search won't match with the patient. Instead we can search based on the full name to guarantee a result.
|
benilovj
approved these changes
Aug 18, 2025
thomasleese
added a commit
that referenced
this pull request
Aug 19, 2025
Fix flaky consent matching test
thomasleese
added a commit
that referenced
this pull request
Aug 20, 2025
Fix flaky consent matching test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously searching for patients based on their first name, which in most cases will return a response, but if the randomly generated first name is a lot shorter than the last name then the search won't match with the patient.
Instead we can search based on the full name to guarantee a result.