Handle nil vaccination record location
#4321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
systm-one-no-location
branch
from
5e98cfc to
0b6af9f
Compare
In the SystmOne exporter. This situation can occur if a vaccination is recorded in the community clinic, where the `location` will be `nil`, and the `location_name` will be set instead. This change was made in aae7b83, previously vaccination records in the generic clinic would have a location of the generic clinic, but we want to move to a world where the location is the specific community clinic where the record took place. This error was spotted by the regression tests and fixes this Sentry error: https://good-machine.sentry.io/issues/6818602795/
thomasleese
force-pushed
the
systm-one-no-location
branch
from
0b6af9f to
5a9f91d
Compare
|
jhenderson
reviewed
Aug 19, 2025
jhenderson
approved these changes
Aug 19, 2025
thomasleese
added a commit
that referenced
this pull request
Aug 19, 2025
Handle `nil` vaccination record location
thomasleese
added a commit
that referenced
this pull request
Aug 20, 2025
Handle `nil` vaccination record location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the SystmOne exporter. This situation can occur if a vaccination is recorded in the community clinic, where the
locationwill benil, and thelocation_namewill be set instead.This change was made in aae7b83, previously vaccination records in the generic clinic would have a location of the generic clinic, but we want to move to a world where the location is the specific community clinic where the record took place.
This error was spotted by the regression tests and fixes this Sentry error: https://good-machine.sentry.io/issues/6818602795/