Replace Gillick assessment patient session foreign key #4365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhenderson
approved these changes
Aug 21, 2025
thomasleese
force-pushed
the
gillick-assessment-patient-session-foreign-key
branch
from
474a28c to
6d0aa79
Compare
It's not being used anywhere so it can be safely removed. Jira-Issue: MAV-1818
This replaces the foreign key association between Gillick assessments and patient sessions to instead link directly to the patient and the session (via the date). This is needed as we eventually want to replace the `PatientSession` model and to do that we need to make sure all foreign keys to it have been replaced. The functionality should be the same before and after, actually slightly improved as Gillick assessment is only supposed to exist on the day it happened, so now we link directly to the session date rather than the overall session. Jira-Issue: MAV-1818
thomasleese
force-pushed
the
gillick-assessment-patient-session-foreign-key
branch
from
6d0aa79 to
0c9e319
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the foreign key association between Gillick assessments and patient sessions to instead link directly to the patient and the session (via the date). This is needed as we eventually want to replace the
PatientSessionmodel and to do that we need to make sure all foreign keys to it have been replaced.The functionality should be the same before and after, actually slightly improved as Gillick assessment is only supposed to exist on the day it happened, so now we link directly to the session date rather than the overall session.
Jira Issue - MAV-1818