Precompile fewer assets, remove service worker #4397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to rip this out, I've been thinking it should be ripped out recently myself. I think we should take the 🪓 to the documentation at the same time is the right thing to do too. |
|
@misaka When you have a moment, could you take a look at 8906cfa? I think this removes all the relevant documentation, in the correct way (he says, walking around blindly in PlantUML). I’ve left https://github.com/nhsuk/manage-vaccinations-in-schools/blob/main/docs/secure-offline-storage.md as that appears to document the different approaches we looked at, without suggesting any of them were implemented. |
thomasleese
approved these changes
Aug 27, 2025
This was intended for offline recording, but has been disabled prior to the pilot.
thomasleese
force-pushed
the
assets-precompile
branch
from
8906cfa to
b3f214c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 uncontroversial things:
govuk-frontendasset files from being precompiled (we don’t use them).scssfiles from being precompiled (these are only used for thebuild:cssscript, which saves a compiled CSS file to/app/assets/build)It also does 1 potentially controversial thing:
This is dead code. The line that imports the service worked has been commented out since January 2024 (we currently use spreadsheets for offline working). The service worker scripts haven’t been updated alongside other changes so I’m wondering if any of it actually works now.
If we are happy removing the service worker, there is also documentation in the repo that says we use a service worker; should that be updated/removed too?