Fix tests outside of preparation period #4453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been renamed to `govuk_back_link`, but actually we don't need it since this page has breadcrumbs.
Using this for booleans results in a warning explaining that it can't fully be tested due to type conversions.
This updates a number of tests that are now failing due to the current date being outside the preparation period. Where possible I've tried to avoid freezing time, but in most cases it's necessary to make sure we're always testing inside or outside a preparation period.
This ensures that when creating a session in the seeds, the date fits within the range of suitable dates for the current academic year. This fixes running the tests on the first and last day of the preparation period.
|
benilovj
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates a number of tests that are now failing due to the current date being outside the preparation period. Where possible I've tried to avoid freezing time, but in most cases it's necessary to make sure we're always testing inside or outside a preparation period.