-
Notifications
You must be signed in to change notification settings - Fork 9
PDS lookup timeline #4462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
murugapl
wants to merge
3
commits into
next
Choose a base branch
from
pds-lookup-timeline
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PDS lookup timeline #4462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a59eadc
to
5ae0464
Compare
399e413
to
1d09920
Compare
1d09920
to
e19cce6
Compare
e63a8bb
to
289cf9b
Compare
7a3f21e
to
37f44ac
Compare
thomasleese
reviewed
Sep 11, 2025
visually_hidden_text: "NHS number" | ||
) | ||
elsif (href = pds_search_history_link) | ||
row.with_action(text: "PDS history", href:, visually_hidden_text: "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
row.with_action(text: "PDS history", href:, visually_hidden_text: "") | |
row.with_action(text: "PDS history", href:) |
I think you can leave this out of it's not needed.
37f44ac
to
bb37d1c
Compare
Component to view events in a timelien format. This will be used by the PDS lookup history feature, and eventually the activity log too.
Adds a view that can be reached from the global patient record, to view the patient's latest PDS lookup history. This link only appears if there are any PDSSearchResults for the patient and their current NHS number matches the number from the last search result set.
Adds tests for PDS lookup history methods and the new timeline component.
bb37d1c
to
d2838b8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event a user finds an NHS number has been added to the patient incorrectly, they might want to investigate where this NHS number has come from. We surface the PDS search history that has brought in the current NHS number on a patient.
https://nhsd-jira.digital.nhs.uk/browse/MAV-1815