Add ReportingAPI::VaccinationEvent model #4484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldavidson
force-pushed
the
add-reporting-api-vaccination-event-table-and-model
branch
3 times, most recently
from
9cf2151 to
5bc861b
Compare
thomasleese
reviewed
Sep 3, 2025
spec/models/concerns/reporting_api/denormalizing_concern_spec.rb
Outdated
Show resolved
Hide resolved
thomasleese
reviewed
Sep 3, 2025
aldavidson
force-pushed
the
add-reporting-api-vaccination-event-table-and-model
branch
from
c2f3040 to
4e6f42b
Compare
thomasleese
reviewed
Sep 3, 2025
thomasleese
approved these changes
Sep 4, 2025
aldavidson
force-pushed
the
add-reporting-api-vaccination-event-table-and-model
branch
from
5ee373c to
94b7f70
Compare
aldavidson
commented
Sep 4, 2025
aldavidson
force-pushed
the
add-reporting-api-vaccination-event-table-and-model
branch
from
c6c6cb3 to
5e4305d
Compare
…nt to always be not-null
aldavidson
force-pushed
the
add-reporting-api-vaccination-event-table-and-model
branch
from
5e4305d to
ed11899
Compare
|
aldavidson
deleted the
add-reporting-api-vaccination-event-table-and-model
branch
aldavidson
pushed a commit
that referenced
this pull request
Sep 4, 2025
aldavidson
pushed a commit
that referenced
this pull request
Sep 4, 2025
…ental remnant from another branch that crept in during final rebasing of #4484
aldavidson
pushed a commit
that referenced
this pull request
Sep 4, 2025
This was referenced Sep 4, 2025
murugapl
pushed a commit
that referenced
this pull request
Sep 10, 2025
…ental remnant from another branch that crept in during final rebasing of #4484
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An 'Under the hood' PR which adds a DB table, model class and tests for
ReportingAPI::VaccinationEvents.This table is intended to store a denormalized copy of the essential fields from the (complex) Mavis model around vaccinations, in a form which is much more suitable for analytic queries - a single table with many columns.
This is admittedly space inefficient, but pretty common standard practice for scalable reporting functions, and a convenient way of separating the operational and analytical workloads. In future this table could well end up being moved to a separate datasource (another RDS instance, or Redshift if it gets v. large, etc). For now, it wlll be ok in the standard datasource, but the move can easily be done per-model class with a one-liner plus some config.
This model is not populated or used anywhere yet - separate PRs will do that.