Use Sidekiq for comms and add rate limits #4502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benilovj
approved these changes
Sep 3, 2025
thomasleese
force-pushed
the
sidekiq-email-sms
branch
6 times, most recently
from
1598018 to
1551b30
Compare
This moves the jobs related to sending emails and SMSs to use Sidekiq instead of Good Job as part of our general move towards Sidekiq.
This limits the number of requests we send to GOV.UK Notify each minute to ensure that we stay within their rate limits. If we were to breach these limits, the jobs would keep retrying until they succeed.
In test and QA we send emails using team API keys, which fails for most users but will allow emails and SMSs to be sent to users in the guest list. This change will prevent these failures from causing the jobs to be retried and instead the job is considered a success.
thomasleese
force-pushed
the
sidekiq-email-sms
branch
from
eda96f8 to
4827244
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the jobs which send emails and text messages to use Sidekiq as part of our general move towards using Sidekiq instead of Good Job. This allows us to get automatic job failure retries and also allows us to enable rate limiting to match GOV.UK Notify's rate limit.