Ensure incorrect vaccine given message isn't shown #4520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhenderson
approved these changes
Sep 4, 2025
thomasleese
force-pushed
the
fix-warning-not-matching
branch
from
aa48e80 to
afd7c2a
Compare
thomasleese
force-pushed
the
fix-warning-not-matching
branch
7 times, most recently
from
afb976e to
1e5dd49
Compare
Once a patient has been vaccinated, their list of approved vaccine methods is empty (they're not approved for any vaccines because they're already vaccinated), therefore we were always showing a message saying that the vaccine method recorded is not an approved vaccine method for this patient. It looks like this broken when we introduced a new consent status of not required (5eac3c4) although before that it would also have been showing if the approved method originally came from triage. Jira-Issue: MAV-1831
thomasleese
force-pushed
the
fix-warning-not-matching
branch
from
1e5dd49 to
6b80503
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once a patient has been vaccinated, their list of approved vaccine methods is empty (they're not approved for any vaccines because they're already vaccinated), therefore we were always showing a message saying that the vaccine method recorded is not an approved vaccine method for this patient.
It looks like this broken when we introduced a new consent status of not required (5eac3c4) although before that it would also have been showing if the approved method originally came from triage.
Jira Issue - MAV-1831