Add denormalised batch to VaccinationRecord
#4550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will be used to store de-normalised versions of this data in the case where these records originate from a historic upload, or from the Imms API. This allows us to dissociate the batch information from the `Team`; it is unlikely that these batches are actually associated with the `Team`, particularly in the Imms API case, where we expect most records to have been recorded by the GP.
alistair-white-horne-tng
force-pushed
the
add-denormalised-batch
branch
2 times, most recently
from
d6e36b3 to
9b84dd4
Compare
When a `VaccinationRecord` is imported without an associated session (implying a historical record), then the batch information should be saved de-normalised.
This also means that the `#from_fhir_record` function no longer needs to require a `team` argument.
This displays the denormalised batch data on the VaccinationRecord view page.
alistair-white-horne-tng
force-pushed
the
add-denormalised-batch
branch
from
9b84dd4 to
4a6b10c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
batch_nameandbatch_expirycolumns toVaccinationRecordThese will be used to store de-normalised versions of this data in the case where these records originate from a historic upload, or from the Imms API. This allows us to dissociate the batch information from the
Team; it is unlikely that these batches are actually associated with theTeam, particularly in the Imms API case, where we expect most records to have been recorded by the GP.