Remove session association from AttendanceRecord
#4553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
prepare-registration-status-location
branch
2 times, most recently
from
50b4f07 to
59b014b
Compare
thomasleese
force-pushed
the
registration-status-patient-session-foreign-key
branch
from
277f8b4 to
823515d
Compare
Base automatically changed from
registration-status-patient-session-foreign-key
to
next
September 9, 2025 14:37
thomasleese
force-pushed
the
prepare-registration-status-location
branch
2 times, most recently
from
0648a92 to
d382b82
Compare
jhenderson
reviewed
Sep 11, 2025
db/migrate/20250908125713_remove_session_from_attendance_record.rb
Outdated
Show resolved
Hide resolved
This renames the model to `AttendanceRecord` to remove the naming of session as the association is going to be removed and replaced instead with a separate location and date column. Jira-Issue: MAV-1938
It's specific to the session so we need to move it out of this model so it can be used when we no longer have an explicit link to the session. Jira-Issue: MAV-1938
This replaces the session association with one to the location instead, as we want registration status to apply across all sessions for a particular location, in preparation for the removal of the `PatientSession` model. Jira-Issue: MAV-1938
thomasleese
force-pushed
the
prepare-registration-status-location
branch
from
d382b82 to
d17b3ff
Compare
|
jhenderson
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the session association with one to the location instead, as we want registration status to apply across all sessions for a particular location, in preparation for the removal of the
PatientSessionmodel.Jira Issue - MAV-1938