Add index on pending_changes <> '{}'
#4635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhenderson
reviewed
Sep 16, 2025
thomasleese
force-pushed
the
pending-changes-index
branch
2 times, most recently
from
a3dff9e to
6d317e8
Compare
This `WHERE` clause is used on each page to render the count of import issues in the navigation bar, therefore we should try and speed up this query as it will have an impact on every page render. Adding an index on this filter should ensure that selecting the number of patients or vaccination records with import issues is quicker. Jira-Issue: MAV-2001
thomasleese
force-pushed
the
pending-changes-index
branch
from
6d317e8 to
29df001
Compare
We make a call to `uniq` later on in the method so there's no need to select on distinct entries here, which should slightly improve the performance of the query, the downside being an increase in memory usage. Jira-Issue: MAV-2001
|
TheOneFromNorway
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
WHEREclause is used on each page to render the count of import issues in the navigation bar, therefore we should try and speed up this query as it will have an impact on every page render. Adding an index on this filter should ensure that selecting the number of patients or vaccination records with import issues is quicker.Jira Issue - MAV-2001