Discard ConsentFormMatchingJob once matched
#4666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
changed the title
ConsentFormMatchingJob once matched
misaka
approved these changes
Sep 19, 2025
At the moment the association is described as many consent forms have the same consent. Whereas in reality it should be one consent form has many consents (one per programme). Jira-Issue: MAV-1897
This ensures that if a consent form has already been matched, the automated process doesn't run and match consents with patients which might result in duplicate consents. This is necessary as we've moved this job to Sidekiq where it will continue to retry if it fails. For example, it might fail due to a bad request from PDS, and continue to do this for the next 21 days. In that time, the consent form may have been matched manually and therefore we would never want the automatic job to succeed.
thomasleese
force-pushed
the
consent-job-skip-if-matched
branch
from
97a1bc3 to
c87bf6a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that if a consent form has already been matched, the automated process doesn't run and match consents with patients which might result in duplicate consents.
This is necessary as we've moved this job to Sidekiq where it will continue to retry if it fails. For example, it might fail due to a bad request from PDS, and continue to do this for the next 21 days. In that time, the consent form may have been matched manually and therefore we would never want the automatic job to succeed.
As part of building this I've also fixed a data model association between consents and consent forms that doesn't quite work as intended.
Jira Issue - MAV-1897