Handle invalid phone errors from GOV.UK Notify #4670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
invalid-phone-error
branch
from
7067144 to
fbbb043
Compare
thomasleese
force-pushed
the
invalid-phone-error
branch
2 times, most recently
from
2550351 to
6976f2a
Compare
This ensures that we handle the `InvalidPhoneError: Not a UK mobile number` error from GOV.UK Notify by recording the response as a permanent failure (which is accurate since retrying is not going to succeed). This also means the job finishes and doesn't get put back on the retry queue, and also allows the nurses to see useful feedback. Sentry-Issue: 6235087330
thomasleese
force-pushed
the
invalid-phone-error
branch
from
6976f2a to
19f75bf
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that we handle the
InvalidPhoneError: Not a UK mobile numbererror from GOV.UK Notify by recording the response as a permanent failure (which is accurate since retrying is not going to succeed). This also means the job finishes and doesn't get put back on the retry queue, and also allows the nurses to see useful feedback.Sentry Issue