Merge pull request #1300 from nhsuk/sass-warning-paths

Fix deprecation warnings for settings and tools `/all` paths

Author: colinrotherham

CHANGELOG.md

@@ -1,5 +1,13 @@
 # NHS.UK frontend Changelog
 
+## 9.5.1 - 14 May 2025
+
+:wrench: **Fixes**
+
+We've made fixes to NHS.UK frontend in the following pull requests:
+
+- [#1300: Fix deprecation warnings for settings and tools `/all` paths](https://github.com/nhsuk/nhsuk-frontend/pull/1300)
+
 ## 9.5.0 - 13 May 2025
 
 :new: **New features**

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "nhsuk-frontend",
-  "version": "9.5.0",
+  "version": "9.5.1",
   "description": "NHS.UK frontend contains the code you need to start building user interfaces for NHS websites and services.",
   "engines": {
     "node": "^20.9.0 || ^22.11.0"

package.json

@@ -0,0 +1,53 @@
+import { compileStringAsync, sassNull } from 'sass-embedded'
+
+describe('Core', () => {
+  /** @type {Logger} */
+  let logger = {}
+
+  beforeEach(() => {
+    // Create a mock warn function that we can use to override the native @warn
+    // function, that we can make assertions about post-render.
+    logger.warn = jest.fn().mockReturnValue(sassNull)
+  })
+
+  describe('importing using "all" files', () => {
+    it('outputs a warning when importing the core "all" file', async () => {
+      const sass = `
+        @forward "core/all";
+      `
+
+      await compileStringAsync(sass, {
+        loadPaths: ['packages'],
+        logger
+      })
+
+      expect(logger.warn).toHaveBeenCalledWith(
+        `Importing using 'core/all' is deprecated. Update your import statement to import 'core'. To silence this warning, update $nhsuk-suppressed-warnings with key: "import-using-all"`,
+        expect.anything()
+      )
+    })
+
+    it('outputs a warning for each layer that has an "all" file', async () => {
+      const sass = `
+        @forward "core/settings/all";
+        @forward "core/tools/all";
+      `
+
+      await compileStringAsync(sass, {
+        loadPaths: ['packages'],
+        logger
+      })
+
+      for (const layer of ['settings', 'tools']) {
+        expect(logger.warn).toHaveBeenCalledWith(
+          `Importing using 'core/${layer}/all' is deprecated. Update your import statement to import 'core/${layer}'. To silence this warning, update $nhsuk-suppressed-warnings with key: "import-using-all"`,
+          expect.anything()
+        )
+      }
+    })
+  })
+})
+
+/**
+ * @import { Logger } from 'sass-embedded'
+ */

packages/core/core.unit.test.mjs

@@ -1,4 +1,4 @@
-@use "settings/warnings" as *;
+@use "warnings" as *;
 @forward ".";
 
 @include nhsuk-warning(

packages/core/settings/_all.scss

@@ -1,4 +1,4 @@
-@use "settings/warnings" as *;
+@use "../settings/warnings" as *;
 @forward ".";
 
 @include nhsuk-warning(