Skip to content

Commit 2e6524a

Browse files
Prefer .nhsuk-frontend-supported to .js-enabled
We must avoid adding styles for Internet Explorer 11 (and other older browsers) where support for `<script type="module">` is not available
1 parent 8fb393c commit 2e6524a

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

backstop.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ module.exports = {
8080
engine_scripts: 'tests/backstop/engine_scripts',
8181
html_report: 'tests/backstop/html_report'
8282
},
83-
readySelector: 'body.js-enabled',
83+
readySelector: 'body.nhsuk-frontend-supported',
8484
report: ['browser'],
8585
scenarios: [
8686
{

docs/contributing/coding-standards.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ Bad:
147147
```scss
148148
.nhsuk-checkboxes__conditional {
149149
// ...
150-
.js-enabled &--hidden {
150+
.nhsuk-frontend-supported &--hidden {
151151
// ...
152152
}
153153
// ...
@@ -161,7 +161,7 @@ Good:
161161
// ...
162162
}
163163

164-
.js-enabled .nhsuk-checkboxes__conditional--hidden {
164+
.nhsuk-frontend-supported .nhsuk-checkboxes__conditional--hidden {
165165
// ...
166166
}
167167
```

packages/components/checkboxes/_index.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,6 @@ $nhsuk-checkboxes-label-padding-left-right: 12px;
150150
}
151151
}
152152

153-
.js-enabled .nhsuk-checkboxes__conditional--hidden {
153+
.nhsuk-frontend-supported .nhsuk-checkboxes__conditional--hidden {
154154
display: none;
155155
}

packages/components/header/_header-base.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@
484484
justify-content: space-between;
485485
}
486486

487-
.js-enabled & {
487+
.nhsuk-frontend-supported & {
488488
flex-wrap: nowrap;
489489
overflow: hidden;
490490
}

packages/components/radios/_index.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,6 @@ $nhsuk-radios-focus-width: $nhsuk-focus-width + 1px;
175175
}
176176
}
177177

178-
.js-enabled .nhsuk-radios__conditional--hidden {
178+
.nhsuk-frontend-supported .nhsuk-radios__conditional--hidden {
179179
display: none;
180180
}

packages/components/tabs/_index.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@
4141
@include nhsuk-responsive-margin(8, "bottom");
4242
}
4343

44-
// JavaScript enabled
45-
.js-enabled {
44+
// ES module JavaScript supported
45+
.nhsuk-frontend-supported {
4646
@include nhsuk-media-query($from: tablet) {
4747
.nhsuk-tabs__list {
4848
border-bottom: 1px solid $nhsuk-border-color;

0 commit comments

Comments
 (0)