Skip to content

Commit 46854f9

Browse files
Merge branch 'main' into header-breaking-changes
2 parents d17095e + 1d0fff5 commit 46854f9

File tree

6 files changed

+17
-5
lines changed

6 files changed

+17
-5
lines changed

.github/dependabot.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
version: 2
2+
updates:
3+
- package-ecosystem: "github-actions"
4+
directory: "/"
5+
schedule:
6+
interval: "monthly"
7+
- package-ecosystem: "npm"
8+
directory: "/"
9+
schedule:
10+
interval: "monthly"

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
- Fix appearance of disabled warning buttons ([Issue 1034]([https://github.com/nhsuk/nhsuk-service-manual-community-backlog/issues/1034]))
88
- Fix reverse button text colour ([PR 1080]([https://github.com/nhsuk/nhsuk-frontend/pull/1080]))
9+
- Fix details component requiring html param in uppercase ([PR 1090](https://github.com/nhsuk/nhsuk-frontend/pull/1090), [Issue 1089](https://github.com/nhsuk/nhsuk-frontend/issues/1089))
910

1011
:boom: **Breaking changes**
1112

app/components/details/index.njk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
{{ details({
1515
"text": "Where can I find my NHS number?",
16-
"HTML": "
16+
"html": "
1717
<p>An NHS number is a 10 digit number, like 485 777 3456.</p>
1818
<p>You can find your NHS number on any document sent to you by the NHS. This may include:</p>
1919
<ul>

gulpfile.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ sass.compiler = require('sass')
2929
function compileCSS() {
3030
return gulp
3131
.src(['packages/nhsuk.scss'])
32-
.pipe(sass())
32+
.pipe(sass().on('error', sass.logError))
3333
.pipe(gulp.dest('dist/'))
3434
.on('error', (err) => {
3535
console.log(err)

packages/components/details/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ For this component to be accessible and compatible with older browsers, include
4545
4646
{{ details({
4747
"text": "Where can I find my NHS number?",
48-
"HTML": "
48+
"html": "
4949
<p>An NHS number is a 10 digit number, like 485 777 3456.</p>
5050
<p>You can find your NHS number on any document sent to you by the NHS. This may include:</p>
5151
<ul>
@@ -259,7 +259,7 @@ The details Nunjucks macro takes the following arguments:
259259
| Name | Type | Required | Description |
260260
| ---------- | ------- | -------- | --------------------------------------------------------------------------------------- |
261261
| text | string | Yes | Text to be displayed on the expander component. |
262-
| HTML | string | Yes | HTML content to be displayed within the expander component |
262+
| html | string | Yes | HTML content to be displayed within the expander component |
263263
| id | string | false | Id to add to the details element. |
264264
| open | boolean | false | If true, details element will be expanded. |
265265
| classes | string | No | Optional additional classes to add to the anchor tag. Separate each class with a space. |

packages/components/details/template.njk

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
</span>
1010
</summary>
1111
<div class="nhsuk-details__text">
12-
{{- params.HTML | safe }}
12+
{# params.HTML supported for backwards compatibility - see issue #1089 #}
13+
{{- (params.html or params.HTML) | safe }}
1314
</div>
1415
</details>

0 commit comments

Comments
 (0)