Skip to content

Commit 9982244

Browse files
paulrobertlloydfrankierobertoanandamaryon1
authored
Update header navigation label (#1073)
* Update header navigation label --------- Co-authored-by: Frankie Roberto <frankie@frankieroberto.com> Co-authored-by: anandamaryon1 <anandamaryon@gmail.com>
1 parent 2097188 commit 9982244

11 files changed

+19
-8
lines changed

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,17 @@
1111
- Fix appearance of disabled warning buttons ([Issue 1034]([https://github.com/nhsuk/nhsuk-service-manual-community-backlog/issues/1034]))
1212
- Fix reverse button text colour ([PR 1080]([https://github.com/nhsuk/nhsuk-frontend/pull/1080]))
1313
- Fix details component requiring html param in uppercase ([PR 1090](https://github.com/nhsuk/nhsuk-frontend/pull/1090), [Issue 1089](https://github.com/nhsuk/nhsuk-frontend/issues/1089))
14+
- Update header navigation label from ’Primary navigation’ to ‘Menu’, and remove superfluous `role` and `id` attributes. To update your HTML, replace:
15+
16+
```html
17+
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
18+
```
19+
20+
with
21+
22+
```html
23+
<nav class="nhsuk-navigation" aria-label="Menu">
24+
```
1425

1526
:boom: **Breaking changes**
1627

app/components/header/index.njk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@
2222
text: 'Mental health'
2323
},
2424
{
25-
'url' : 'https://www.nhs.uk/conditions/social-care-and-support/',
25+
href: 'https://www.nhs.uk/conditions/social-care-and-support/',
2626
text: 'Care and support'
2727
},
2828
{
29-
'url' : 'https://www.nhs.uk/pregnancy/',
29+
href: 'https://www.nhs.uk/pregnancy/',
3030
text: 'Pregnancy'
3131
},
3232
{

packages/components/header/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ compiled JavaScript for all components `nhsuk.min.js` or the individual componen
4242
</div>
4343
<div class="nhsuk-navigation-container">
4444
<div class="nhsuk-width-container">
45-
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
45+
<nav class="nhsuk-navigation" aria-label="Menu">
4646
<ul class="nhsuk-header__navigation-list">
4747
<li class="nhsuk-header__navigation-item">
4848
<a class="nhsuk-header__navigation-link" href="https://www.nhs.uk/conditions">
@@ -144,7 +144,7 @@ compiled JavaScript for all components `nhsuk.min.js` or the individual componen
144144
</div>
145145
<div class="nhsuk-navigation-container">
146146
<div class="nhsuk-width-container">
147-
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
147+
<nav class="nhsuk-navigation" aria-label="Menu">
148148
<ul class="nhsuk-header__navigation-list">
149149
<li class="nhsuk-header__navigation-item">
150150
<a class="nhsuk-header__navigation-link" href="https://www.nhs.uk/conditions">
@@ -363,7 +363,7 @@ compiled JavaScript for all components `nhsuk.min.js` or the individual componen
363363
</div>
364364
<div class="nhsuk-navigation-container">
365365
<div class="nhsuk-width-container">
366-
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
366+
<nav class="nhsuk-navigation" aria-label="Menu">
367367
<ul class="nhsuk-header__navigation-list">
368368
<li class="nhsuk-header__navigation-item">
369369
<a class="nhsuk-header__navigation-link" href="#">
@@ -475,7 +475,7 @@ compiled JavaScript for all components `nhsuk.min.js` or the individual componen
475475
</div>
476476
<div class="nhsuk-navigation-container">
477477
<div class="nhsuk-width-container">
478-
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
478+
<nav class="nhsuk-navigation" aria-label="Menu">
479479
<ul class="nhsuk-header__navigation-list">
480480
<li class="nhsuk-header__navigation-item">
481481
<a class="nhsuk-header__navigation-link" href="#">
@@ -588,7 +588,7 @@ compiled JavaScript for all components `nhsuk.min.js` or the individual componen
588588
</div>
589589
<div class="nhsuk-navigation-container">
590590
<div class="nhsuk-width-container">
591-
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
591+
<nav class="nhsuk-navigation" aria-label="Menu">
592592
<ul class="nhsuk-header__navigation-list">
593593
<li class="nhsuk-header__navigation-item">
594594
<a class="nhsuk-header__navigation-link" href="#">

packages/components/header/template.njk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767

6868
{%- if params.primaryLinks and params.primaryLinks.length > 0 %}
6969
<div class="nhsuk-navigation-container">
70-
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
70+
<nav class="nhsuk-navigation" aria-label="Menu">
7171
<ul class="nhsuk-header__navigation-list {%- if params.primaryLinks.length < 4 %} nhsuk-header__navigation-list--left-aligned{% endif %}">
7272
{%- for item in params.primaryLinks %}
7373
{% set linkInnerContent %}
Loading

0 commit comments

Comments
 (0)