Fix for reverse button in hero (#1292)

frankieroberto · web-flow · commit da49a8c2f1e3 · 2025-05-12T15:03:37.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -208,6 +208,7 @@ After:
 We've made fixes to NHS.UK frontend in the following pull requests:
 
 - [#1258: Fix text input with prefix/suffix focus and width](https://github.com/nhsuk/nhsuk-frontend/pull/1258)
+- [#1292: Fix for reverse buttons within Hero components](https://github.com/nhsuk/nhsuk-frontend/pull/1292)
 
 ## 9.4.1 - 22 April 2025
 
diff --git a/app/components/hero/hero-with-html.njk b/app/components/hero/hero-with-html.njk
@@ -13,7 +13,8 @@
 
     {{ button({
       text: "Sign up",
-      classes: "nhsuk-button--reverse"
+      classes: "nhsuk-button--reverse",
+      href: "#"
     }) }}
   {% endcall %}
 {% endblock %}
diff --git a/packages/components/hero/_index.scss b/packages/components/hero/_index.scss
@@ -18,7 +18,8 @@
 
   @include print-color($nhsuk-print-text-color);
 
-  a {
+  .nhsuk-link,
+  a:not(.nhsuk-button) {
     @include nhsuk-link-style-white;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,8 @@`
`18`	`18`
`19`	`19`	`@include print-color($nhsuk-print-text-color);`
`20`	`20`
`21`		`- a {`
	`21`	`+ .nhsuk-link,`
	`22`	`+ a:not(.nhsuk-button) {`
`22`	`23`	`@include nhsuk-link-style-white;`
`23`	`24`	`}`
`24`	`25`