Fix margin collapse issue

colinrotherham · colinrotherham · commit eb81eec3d762 · 2025-05-20T17:50:06.000+01:00
diff --git a/packages/components/back-link/_index.scss b/packages/components/back-link/_index.scss
@@ -13,11 +13,11 @@
 ////
 
 .nhsuk-back-link {
-  margin-top: nhsuk-spacing(3);
-  line-height: 1; // [5]
+  padding-top: nhsuk-spacing(3);
+  line-height: 1; // [4]
 
   @include nhsuk-media-query($from: tablet) {
-    margin-top: nhsuk-spacing(4);
+    padding-top: nhsuk-spacing(4);
   }
 }
 
diff --git a/packages/components/breadcrumb/_index.scss b/packages/components/breadcrumb/_index.scss
@@ -15,11 +15,11 @@
 ////
 
 .nhsuk-breadcrumb {
-  margin-top: nhsuk-spacing(3);
+  padding-top: nhsuk-spacing(3);
   @include nhsuk-print-hide; // [1]
 
   @include nhsuk-media-query($from: tablet) {
-    margin-top: nhsuk-spacing(4);
+    padding-top: nhsuk-spacing(4);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -13,11 +13,11 @@`
`13`	`13`	`////`
`14`	`14`
`15`	`15`	`.nhsuk-back-link {`
`16`		`- margin-top: nhsuk-spacing(3);`
`17`		`- line-height: 1; // [5]`
	`16`	`+ padding-top: nhsuk-spacing(3);`
	`17`	`+ line-height: 1; // [4]`
`18`	`18`
`19`	`19`	`@include nhsuk-media-query($from: tablet) {`
`20`		`- margin-top: nhsuk-spacing(4);`
	`20`	`+ padding-top: nhsuk-spacing(4);`
`21`	`21`	`}`
`22`	`22`	`}`
`23`	`23`
Original file line number	Diff line number	Diff line change
`@@ -15,11 +15,11 @@`
`15`	`15`	`////`
`16`	`16`
`17`	`17`	`.nhsuk-breadcrumb {`
`18`		`- margin-top: nhsuk-spacing(3);`
	`18`	`+ padding-top: nhsuk-spacing(3);`
`19`	`19`	`@include nhsuk-print-hide; // [1]`
`20`	`20`
`21`	`21`	`@include nhsuk-media-query($from: tablet) {`
`22`		`- margin-top: nhsuk-spacing(4);`
	`22`	`+ padding-top: nhsuk-spacing(4);`
`23`	`23`	`}`
`24`	`24`	`}`
`25`	`25`