Remove legacy browser support with <script type="module">
#1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
force-pushed
the
browser-support
branch
2 times, most recently
from
bc545c3 to
2a1c042
Compare
colinrotherham
force-pushed
the
browser-support
branch
2 times, most recently
from
cbb4457 to
b26d28f
Compare
colinrotherham
changed the title
<script type="module"><script type="module">
sarawilcox
reviewed
May 1, 2025
There was a problem hiding this comment.
I'm OK with this. There are a few teeny stylistic things I'd normally change (quotation marks) but I don't think it's necessary and would probably only make it inconsistent with other files in the frontend.
Worth asking @mcheung-nhs to cast an eye over the assistive tech bit.
sarawilcox
reviewed
May 1, 2025
colinrotherham
force-pushed
the
browser-support
branch
from
b26d28f to
d128a9a
Compare
3 tasks
colinrotherham
force-pushed
the
browser-support
branch
2 times, most recently
from
1926345 to
942d9bf
Compare
We must avoid adding styles for Internet Explorer 11 (and other older browsers) where support for `<script type="module">` is not available
colinrotherham
force-pushed
the
browser-support
branch
from
942d9bf to
72b741e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR drops JavaScript support for Internet Explorer and other older browsers
Closes #1236
Checklist