From 2a3654d5d64a59f1307f1c778ff0b9c0d336d72a Mon Sep 17 00:00:00 2001 From: Paul Robert Lloyd Date: Wed, 9 Oct 2024 23:43:38 +0100 Subject: [PATCH 1/5] Use single path for NHS logo in header --- .../components/header/_header-service.scss | 7 ---- packages/components/header/_header-white.scss | 14 +++---- packages/components/header/_header.scss | 37 +++++-------------- packages/components/header/template.njk | 17 ++++----- 4 files changed, 24 insertions(+), 51 deletions(-) diff --git a/packages/components/header/_header-service.scss b/packages/components/header/_header-service.scss index a14e4556e..5b2595ca9 100644 --- a/packages/components/header/_header-service.scss +++ b/packages/components/header/_header-service.scss @@ -16,13 +16,6 @@ width: auto; } - &:hover { - background: none; - - .nhsuk-header__service-name { - text-decoration: underline; - } - } &:focus { background: $nhsuk-focus-color; diff --git a/packages/components/header/_header-white.scss b/packages/components/header/_header-white.scss index a59a610c4..d8f9d9159 100644 --- a/packages/components/header/_header-white.scss +++ b/packages/components/header/_header-white.scss @@ -20,13 +20,7 @@ } .nhsuk-logo { - .nhsuk-logo__background { - fill: $color_nhsuk-blue; - } - - .nhsuk-logo__text { - fill: $color_nhsuk-white; - } + color: $color_nhsuk-blue; } .nhsuk-header__link { @@ -38,6 +32,12 @@ color: $nhsuk-text-color; } } + + &:focus { + .nhsuk-logo { + color: $nhsuk-text-color; + } + } } .nhsuk-search__submit { diff --git a/packages/components/header/_header.scss b/packages/components/header/_header.scss index 36d0e7a55..f6b052f29 100644 --- a/packages/components/header/_header.scss +++ b/packages/components/header/_header.scss @@ -43,31 +43,6 @@ z-index: 1; } - .nhsuk-logo__background { - fill: $color_nhsuk-white; - - @include mq($media-type: print) { - fill: $color_nhsuk-blue; - } - } - - .nhsuk-logo__text { - fill: $color_nhsuk-blue; - - @include mq($media-type: print) { - fill: $color_nhsuk-white; - } - } - - @include mq($from: tablet) { - padding-left: 0; - } - - .nhsuk-logo { - @include nhsuk-logo-size; - border: 0; - } - @include mq($until: desktop) { max-width: 60%; } @@ -79,18 +54,24 @@ .nhsuk-header__link { @include nhsuk-logo-size; + @include nhsuk-link-style-white; display: block; &:hover { + text-decoration: underline; + .nhsuk-logo { - box-shadow: 0 0 0 $nhsuk-focus-width $color_shade_nhsuk-blue-35; + box-shadow: 0 $nhsuk-focus-width $color_shade_nhsuk-blue-35; } } - &:focus { - box-shadow: none; + &:active { + color: $color_nhsuk-white; + } + &:focus { .nhsuk-logo { + background-color: $nhsuk-focus-color; box-shadow: 0 0 0 $nhsuk-focus-width $nhsuk-focus-color, 0 $nhsuk-focus-width 0 $nhsuk-focus-width $nhsuk-focus-text-color; diff --git a/packages/components/header/template.njk b/packages/components/header/template.njk index 5419e7627..73fa2d29e 100644 --- a/packages/components/header/template.njk +++ b/packages/components/header/template.njk @@ -5,9 +5,8 @@ {% set showSearch = params.showSearch if params.showSearch else "false" %} {% set nhsLogo %} -
- - + {%- if showNav == "false" and showSearch == "false"%} @@ -50,11 +49,11 @@ - + {%- endif %}
{# close nhsuk-header__container #} - + {% endif -%} @@ -135,7 +134,7 @@ {% if showNav == "true" and params.primaryLinks and showSearch == "false" %} {# close nhsuk-header__container #} - +