Header updates - breaking changes #1058
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulrobertlloyd found an issue with your logo SVG change (#1047), when printing the NHS logo no longer shows. Not looked into the code but I assume it's just missing a rule to change it's colour from white to blue on print? |
paulrobertlloyd
force-pushed
the
header-breaking-changes
branch
from
c2ccf58 to
fa05a47
Compare
3 tasks
3 tasks
paulrobertlloyd
force-pushed
the
header-breaking-changes
branch
from
f5a7da9 to
08add40
Compare
This was referenced Nov 27, 2024
Removes the link to `"/"` labelled `"Home"`, which is currently hardcoded, and only shows up within the navigation menu on mobile screen widths. This link may not be appropriate for all services, which might not have a homepage, or might use a different path for it. It is also unclear whether having a homepage link is always needed in the navigation if the NHS logo also goes to the homepage.
paulrobertlloyd
force-pushed
the
header-breaking-changes
branch
from
9ab62ce to
a1ee8c1
Compare
|
@paulrobertlloyd could we avoid force pushing to this branch for a bit? Makes it harder to maintain the other pull requests into this branch. We can sort out the commit history at the end? |
Co-authored-by: Colin Rotherham <work@colinr.com>
Co-authored-by: Colin Rotherham <work@colinr.com>
…cro-options Update macro options for new header
|
We're getting close 😱 Merged with |
|
@frankieroberto @paulrobertlloyd Can I check which one of these is correct? Could do with some fixes adding Mobile
Tablet
|
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bringing together a series of breaking changes from the following PRs:
Todo
.nhsuk-navigationtonhsuk-header__navigationChecklist