-
Notifications
You must be signed in to change notification settings - Fork 111
Header updates - breaking changes #1058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anandamaryon1
wants to merge
125
commits into
main
Choose a base branch
from
header-breaking-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 107 commits
Commits
Show all changes
125 commits
Select commit
Hold shift + click to select a range
fd5d82e
Remove hardcoded Home link from navigation
frankieroberto 1d564ed
Add 'Home' to examples
frankieroberto 010afb0
Use single path for NHS logo in header
paulrobertlloyd f24cdf3
Update CHANGELOG with updated SVG logo
paulrobertlloyd 95d5aa6
Update SVG in README for header component
paulrobertlloyd 8499270
Format header styles with Prettier
paulrobertlloyd f4c1c93
Simplify template logic for header component
paulrobertlloyd 9c192c7
Allow transactional service name in header alongside navigation and s…
paulrobertlloyd 4fc2b53
Update CHANGELOG.md
paulrobertlloyd 611c2ef
Ensure logo in header appears for print media
paulrobertlloyd 82b4b41
Refactor header styles
paulrobertlloyd e45d809
Update header README to account for recent markup changes
paulrobertlloyd 64afec5
Update backstop reference images for header component
paulrobertlloyd a1ee8c1
Remove home link from header navigation
paulrobertlloyd 230bf09
Change primaryLinks to use href and text instead of url and label (#1…
frankieroberto 51b1929
Fix changelog merge
frankieroberto 7b55d10
Fix CHANGELOG
frankieroberto 9c49e84
Actually fix changelog
frankieroberto d17095e
Add changelog item
frankieroberto 46854f9
Merge branch 'main' into header-breaking-changes
frankieroberto 53a7e11
Add current item indicator for header navigation (#1067)
frankieroberto 2097188
Describe the active and current arguments in header (#1098)
frankieroberto 9982244
Update header navigation label (#1073)
paulrobertlloyd 00fe295
Show account information and links in the header (#1063)
paulrobertlloyd 457f00c
tidy header examples
anandamaryon1 1a2e12b
run prettier on header README
anandamaryon1 b746e73
Update backstop refernece images
anandamaryon1 9fc5b2e
Merge branch 'main' into header-breaking-changes
frankieroberto ed69c88
update changelog
anandamaryon1 3f60fff
edit account header rbac example placeholder
anandamaryon1 3310b1e
Merge branch 'main' into header-breaking-changes
frankieroberto e8fd520
Enable inline styles in tests
frankieroberto 9b32d44
Style fix
frankieroberto 0dfb446
Merge branch 'main' into header-breaking-changes
colinrotherham c2a1539
Fix Stylelint issues
colinrotherham a57b40f
Approve minor changes to backstop images
frankieroberto 5713bb3
Merge branch 'main' into header-breaking-changes
colinrotherham 150fea0
Add layout blocks from GOV.UK Frontend
colinrotherham 9b4f3e2
Fix HTML validation moving `<style>` to head
colinrotherham e046683
Make justification of items in header navigation opt-in
paulrobertlloyd 130909d
Wrap header navigation items when JavaScript is not enabled
paulrobertlloyd 9428747
Add space between header navigation items using padding
paulrobertlloyd 6b99d49
Update backstop images to reflect left aligned navigation in header c…
paulrobertlloyd 55ac87e
Update changelog to reflect left aligned navigation in header component
paulrobertlloyd 423b70b
Merge pull request #1138 from nhsuk/header-navigation-spacing
paulrobertlloyd 4e644b7
Support form submission from header account items
paulrobertlloyd b1bcf63
Merge pull request #1155 from nhsuk/header-account-buttons
paulrobertlloyd 38c2556
Update CHANGELOG to incluce header account features
paulrobertlloyd 728ce97
Merge branch 'main' into header-breaking-changes
frankieroberto 204cb66
Header breaking changes - update nunjucks params (#1109)
frankieroberto 3d49d16
Ensure templating for header service logo and name is more readable
paulrobertlloyd 50fccc5
Tidy up syntax for header component examples
paulrobertlloyd d534ba8
Update header backstop images
paulrobertlloyd 5d7c9e1
.nhsuk-header__service-logo is always a link, so don’t need to check …
paulrobertlloyd 9aaeeb5
Remove conditionally added class previously used to left-align naviga…
paulrobertlloyd e034f23
Merge remote-tracking branch 'origin/main' into header-breaking-changes
anandamaryon1 27bd75a
fixes from merge, inc. swapping layout.njk to example.njk for header …
anandamaryon1 bbfb877
update visual test images
anandamaryon1 26bf31c
Merge branch 'main' into header-breaking-changes
anandamaryon1 f196a84
Add word-break to account links and buttons to prevent long words fro…
anandamaryon1 c5cc9ed
Update CHANGELOG.md
anandamaryon1 30991b9
Update CHANGELOG.md
anandamaryon1 a9a5e5e
Update CHANGELOG.md
anandamaryon1 f1f4d48
Update CHANGELOG.md
anandamaryon1 694ce22
Update CHANGELOG.md
anandamaryon1 04cf33a
remove self-closing / from img in org header
anandamaryon1 748f4d2
add overflow wrap to account header item, in addition to links and bu…
anandamaryon1 37fa2cd
fix header primaryLinks href (from url)
anandamaryon1 06dd726
tweak account header user icon svg, add file
anandamaryon1 c806856
tweak account header user icon svg
paulrobertlloyd 549fd02
Move header-specific icon styles into header css. Add flex-shrink to …
anandamaryon1 8793ac6
Merge branch 'main' into header-breaking-changes
colinrotherham 6362e85
Update reference images
colinrotherham 80dcd0e
Update reference images
colinrotherham 42eab67
Merge branch 'header-calculation' into header-breaking-changes
colinrotherham 801c385
Merge branch 'header-calculation' into header-breaking-changes
colinrotherham 24c5626
Merge branch 'main' into header-breaking-changes
colinrotherham 9d48280
Rename .nhs-logo to .nhsuk-header__logo
paulrobertlloyd f732aad
Rename .nhsuk-organisation-* to .nhsuk-header__organisation-*
paulrobertlloyd 7830ca5
Rename .nhsuk-header__navigation-item-active-fallback to .nhsuk-heade…
paulrobertlloyd 97351c4
Rename .nhsuk-navigation-container to .nhsuk-header__navigation
paulrobertlloyd e37e9ab
Rename .nhsuk-navigation to .nhsuk-header__navigation-container
paulrobertlloyd e02d002
Move .nhsuk-header__drop-down and nhsuk-mobile-menu-container classes…
paulrobertlloyd 3b9e76f
Rename .nhsuk-search__input to .nhsuk-header__search-input and nhsuk-…
paulrobertlloyd e4d287e
Rename .nhsuk-header--white-nav to nhsuk-header--white-navigation
paulrobertlloyd f2efb19
Nest contain div element with navigation nav element
paulrobertlloyd 19cce71
Align variables in header.js with updated class names
paulrobertlloyd 293b4d5
Re-order header styles
paulrobertlloyd a7f27f3
Use hidden attributes instead of classes to manage header menu visibi…
paulrobertlloyd 28717ad
Remove .nhsuk-header__search-wrap container
paulrobertlloyd 81ef524
Use generic search element for header search container
paulrobertlloyd 0c761de
Tidy up header component template
paulrobertlloyd f93e0d9
Update changelog with new header class names
anandamaryon1 c4fecb2
Move header specific .nhsuk-icon__chevron-down styles into _header.scss
paulrobertlloyd b58162f
Remove JS enhancements from example
colinrotherham bcfcf93
Remove `hidden` from toggle button
colinrotherham edd49f9
Append menu list after `hidden` attribute
colinrotherham 5bb4d15
Review feedback
colinrotherham 9cf653a
Fix tests to use `hidden` attribute
colinrotherham b0388c6
Add support for older browsers
colinrotherham 761bd08
Update reference images
colinrotherham 14b1eb1
Set defaults before early return
colinrotherham 2d4da24
Merge pull request #1234 from nhsuk/header-bem
paulrobertlloyd a8fb776
Merge branch 'main' into header-breaking-changes
colinrotherham fdcad1b
Update reference images
colinrotherham 57bb80d
Merge branch 'main' into header-breaking-changes
colinrotherham bae1f52
Merge header variant SASS into single file (#1247)
frankieroberto b3bc853
Update packages/components/header/README.md
frankieroberto 68e2973
Merge branch 'main' into header-breaking-changes
frankieroberto 24cddac
Merge branch 'main' into header-breaking-changes
colinrotherham a7f2947
Move header changelog entry to unreleased
colinrotherham 147e8e2
Update macro options for new header
frankieroberto c611e52
Add search placeholder
colinrotherham fb466f2
Update base URL description
colinrotherham bf3ad5e
Merge pull request #1267 from nhsuk/header-breaking-changes-update-ma…
anandamaryon1 3cc210f
Merge branch 'main' into header-breaking-changes
anandamaryon1 4c372b1
Update changelog
anandamaryon1 2cfeebd
Change Health-Z to Health A to Z
frankieroberto a6e6f5a
Remove leading space
frankieroberto 822f8cc
update changelog, remove snippets and point to service manual instead
anandamaryon1 ee2af2b
Merge branch 'main' into header-breaking-changes
colinrotherham d136512
Update reference images
colinrotherham 15388fb
Merge branch 'main' into header-breaking-changes
frankieroberto c8966ec
Merge branch 'main' into header-breaking-changes
colinrotherham 5abb89b
Remove deleted header paths from test
colinrotherham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
{% set title = "Header with account (logged in)" %} | ||
{% from "components/header/macro.njk" import header %} | ||
{% extends 'example.njk' %} | ||
|
||
{% block main %} | ||
{{ header({ | ||
service: { | ||
text: "Manage patients" | ||
}, | ||
account: { | ||
items: [ | ||
{ | ||
href: "#", | ||
text: "florence.nightingale@nhs.net", | ||
icon: true | ||
}, | ||
{ | ||
action: "#", | ||
text: "Log out" | ||
} | ||
] | ||
}, | ||
primaryLinks: [ | ||
{ | ||
href: "#", | ||
text: "Home" | ||
}, | ||
{ | ||
href: "#", | ||
text: "Services" | ||
}, | ||
{ | ||
href: "#", | ||
text: "Your health" | ||
}, | ||
{ | ||
href: "#", | ||
text: "Messages" | ||
}, { | ||
href: "#", | ||
text: "Help and support" | ||
} | ||
] | ||
}) }} | ||
{% endblock %} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
{% set title = "Header with account (logged out)" %} | ||
{% from "components/header/macro.njk" import header %} | ||
{% extends 'example.njk' %} | ||
|
||
{% block main %} | ||
{{ header({ | ||
service: { | ||
text: "Manage patients" | ||
}, | ||
account: { | ||
items: [ | ||
{ | ||
href: "#", | ||
text: "Log in" | ||
} | ||
] | ||
} | ||
}) }} | ||
{% endblock %} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
{% set title = "Header with account (logged in, RBAC)" %} | ||
{% from "components/header/macro.njk" import header %} | ||
{% extends 'example.njk' %} | ||
|
||
{% block main %} | ||
{{ header({ | ||
service: { | ||
text: "Manage patients" | ||
}, | ||
search: { | ||
placeholder: "NHS number, date of birth", | ||
visuallyHiddenLabel: "Search for a user" | ||
}, | ||
account: { | ||
items: [ | ||
{ | ||
href: "#", | ||
text: "Florence Nightingale", | ||
icon: true | ||
}, | ||
{ | ||
text: "RA Manager, Hull and East Yorkshire Hospitals NHS Trust (RWA)" | ||
}, | ||
{ | ||
href: "#", | ||
text: "Change role" | ||
}, | ||
{ | ||
action: "#", | ||
text: "Log out" | ||
} | ||
] | ||
}, | ||
primaryLinks: [ | ||
{ | ||
href: "#", | ||
text: "Home" | ||
}, | ||
{ | ||
href: "#", | ||
text: "Create user" | ||
}, | ||
{ | ||
href: "#", | ||
text: "Find user" | ||
} | ||
] | ||
}) }} | ||
{% endblock %} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
{% set title = "Header organisational with white header and account" %} | ||
{% from "components/header/macro.njk" import header %} | ||
{% extends 'example.njk' %} | ||
|
||
{% block main %} | ||
{{ header({ | ||
classes: "nhsuk-header--white nhsuk-header--white-navigation", | ||
logo: { | ||
href: "#" | ||
}, | ||
organisation: { | ||
name: "Anytown Anyplace", | ||
split: "Anywhere", | ||
descriptor: "NHS Foundation Trust" | ||
}, | ||
search: { | ||
visuallyHiddenLabel: "Search the Anytown Anyplace Anywhere website" | ||
}, | ||
account: { | ||
items: [ | ||
{ | ||
text: "Florence Nightingale", | ||
icon: true | ||
}, | ||
{ | ||
action: "#", | ||
text: "Log out" | ||
} | ||
] | ||
}, | ||
primaryLinks: [ | ||
{ | ||
href: "#", | ||
text: "Your hospital visit" | ||
}, | ||
{ | ||
href: "#", | ||
text: "Wards and departments" | ||
}, | ||
{ | ||
href: "#", | ||
text: "Conditions and treatments" | ||
}, | ||
{ | ||
href: "#", | ||
text: "Our people" | ||
}, | ||
{ | ||
href: "#", | ||
text: "Our research" | ||
} | ||
] | ||
}) }} | ||
{% endblock %} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.