-
Notifications
You must be signed in to change notification settings - Fork 111
Left align header navigation items by default #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
paulrobertlloyd
merged 5 commits into
header-breaking-changes
from
header-navigation-spacing
Mar 13, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e046683
Make justification of items in header navigation opt-in
paulrobertlloyd 130909d
Wrap header navigation items when JavaScript is not enabled
paulrobertlloyd 9428747
Add space between header navigation items using padding
paulrobertlloyd 6b99d49
Update backstop images to reflect left aligned navigation in header c…
paulrobertlloyd 55ac87e
Update changelog to reflect left aligned navigation in header component
paulrobertlloyd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-61 Bytes
(99%)
...op/bitmaps_reference/nhsuk-frontend_Header_default_0_document_0_iPhone_5_SE.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-963 Bytes
(91%)
...top/bitmaps_reference/nhsuk-frontend_Header_default_0_document_1_iPhone_6-8.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.58 KB
(91%)
.../backstop/bitmaps_reference/nhsuk-frontend_Header_default_0_document_2_iPad.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.85 KB
(89%)
...tmaps_reference/nhsuk-frontend_Header_default_0_document_3_Surface_iPad_Pro.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.2 KB
(91%)
...maps_reference/nhsuk-frontend_Header_organisational_0_document_1_iPhone_6-8.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.47 KB
(93%)
...op/bitmaps_reference/nhsuk-frontend_Header_organisational_0_document_2_iPad.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.58 KB
(89%)
...eference/nhsuk-frontend_Header_organisational_0_document_3_Surface_iPad_Pro.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.2 KB
(91%)
...uk-frontend_Header_organisational_with_white_header_0_document_1_iPhone_6-8.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.45 KB
(93%)
...ce/nhsuk-frontend_Header_organisational_with_white_header_0_document_2_iPad.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.57 KB
(89%)
...ntend_Header_organisational_with_white_header_0_document_3_Surface_iPad_Pro.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.49 KB
(91%)
...Header_organisational_with_white_header_and_account_0_document_1_iPhone_6-8.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3.03 KB
(88%)
...ntend_Header_organisational_with_white_header_and_account_0_document_2_iPad.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.94 KB
(89%)
..._organisational_with_white_header_and_account_0_document_3_Surface_iPad_Pro.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.2 KB
(91%)
...der_organisational_with_white_header_and_navigation_0_document_1_iPhone_6-8.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.45 KB
(93%)
...nd_Header_organisational_with_white_header_and_navigation_0_document_2_iPad.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.53 KB
(89%)
...ganisational_with_white_header_and_navigation_0_document_3_Surface_iPad_Pro.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.15 KB
(91%)
...nd_Header_with_a_service_name_search_and_navigation_0_document_1_iPhone_6-8.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.54 KB
(92%)
...frontend_Header_with_a_service_name_search_and_navigation_0_document_2_iPad.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.72 KB
(91%)
...der_with_a_service_name_search_and_navigation_0_document_3_Surface_iPad_Pro.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.16 KB
(91%)
...rence/nhsuk-frontend_Header_with_account_logged_in_0_document_0_iPhone_5_SE.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.22 KB
(92%)
...erence/nhsuk-frontend_Header_with_account_logged_in_0_document_1_iPhone_6-8.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.47 KB
(92%)
...ps_reference/nhsuk-frontend_Header_with_account_logged_in_0_document_2_iPad.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+329 Bytes
(100%)
.../nhsuk-frontend_Header_with_account_logged_in_0_document_3_Surface_iPad_Pro.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.04 KB
(91%)
.../nhsuk-frontend_Header_with_account_logged_in_RBAC_0_document_0_iPhone_5_SE.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.78 KB
(88%)
...e/nhsuk-frontend_Header_with_account_logged_in_RBAC_0_document_1_iPhone_6-8.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.7 KB
(90%)
...ference/nhsuk-frontend_Header_with_account_logged_in_RBAC_0_document_2_iPad.png
Oops, something went wrong.
Binary file modified
BIN
-2.82 KB
(89%)
...k-frontend_Header_with_account_logged_in_RBAC_0_document_3_Surface_iPad_Pro.png
Oops, something went wrong.
Binary file modified
BIN
-2.04 KB
(91%)
...frontend_Header_with_account_logged_in_custom_html_0_document_0_iPhone_5_SE.png
Oops, something went wrong.
Binary file modified
BIN
-2.78 KB
(88%)
...-frontend_Header_with_account_logged_in_custom_html_0_document_1_iPhone_6-8.png
Oops, something went wrong.
Binary file modified
BIN
-2.7 KB
(90%)
.../nhsuk-frontend_Header_with_account_logged_in_custom_html_0_document_2_iPad.png
Oops, something went wrong.
Binary file modified
BIN
-2.82 KB
(89%)
...end_Header_with_account_logged_in_custom_html_0_document_3_Surface_iPad_Pro.png
Oops, something went wrong.
Binary file modified
BIN
-350 Bytes
(98%)
...frontend_Header_with_account_navigation_and_search_0_document_0_iPhone_5_SE.png
Oops, something went wrong.
Binary file modified
BIN
-1.34 KB
(92%)
...-frontend_Header_with_account_navigation_and_search_0_document_1_iPhone_6-8.png
Oops, something went wrong.
Binary file modified
BIN
-1.57 KB
(92%)
.../nhsuk-frontend_Header_with_account_navigation_and_search_0_document_2_iPad.png
Oops, something went wrong.
Binary file modified
BIN
-1.81 KB
(92%)
...end_Header_with_account_navigation_and_search_0_document_3_Surface_iPad_Pro.png
Oops, something went wrong.
Binary file modified
BIN
+130 Bytes
(100%)
...ps_reference/nhsuk-frontend_Header_with_navigation_0_document_0_iPhone_5_SE.png
Oops, something went wrong.
Binary file modified
BIN
-758 Bytes
(91%)
...aps_reference/nhsuk-frontend_Header_with_navigation_0_document_1_iPhone_6-8.png
Oops, something went wrong.
Binary file modified
BIN
-1.41 KB
(90%)
...p/bitmaps_reference/nhsuk-frontend_Header_with_navigation_0_document_2_iPad.png
Oops, something went wrong.
Binary file modified
BIN
-1.58 KB
(89%)
...ference/nhsuk-frontend_Header_with_navigation_0_document_3_Surface_iPad_Pro.png
Oops, something went wrong.
Binary file modified
BIN
-1.5 KB
(90%)
...ference/nhsuk-frontend_Header_with_navigation_open_0_document_0_iPhone_5_SE.png
Oops, something went wrong.
Binary file modified
BIN
-1.31 KB
(91%)
...eference/nhsuk-frontend_Header_with_navigation_open_0_document_1_iPhone_6-8.png
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remember why this class name changed? I’d have expected all the css to be scoped within
.nhsuk-header*
but I might have forgotten something?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven’t changed any class names, just changed which element these styles are applied to.
The classes used in this component are a bit all over the place (as elsewhere). For example, the header contains:
nhsuk-navigation-container
nhsuk-navigation
nhsuk-mobile-menu-container
nhsuk-organisation-*
nhsuk-logo
nhsuk-search__*
If we want to fix this, perhaps something for a different PR?