Skip to content

Add tablet specific grid column widths #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add tablet specific grid column widths #1154

wants to merge 3 commits into from

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Feb 21, 2025 •
edited
Loading

Description

This PR adds tablet specific grid column width classes:

.nhsuk-grid-column-one-quarter-from-tablet
.nhsuk-grid-column-one-third-from-tablet
.nhsuk-grid-column-one-half-from-tablet
.nhsuk-grid-column-two-thirds-from-tablet
.nhsuk-grid-column-three-quarters-from-tablet
.nhsuk-grid-column-full-from-tablet

The feature was suggested as part of #1153 but much more limited in scope (grid classes only)

Checklist

This was referenced Feb 21, 2025
Open
Open
@colinrotherham colinrotherham linked an issue Mar 5, 2025 that may be closed by this pull request
scss @import deprecation - migrate to sass module system / @use #701
Closed
@colinrotherham colinrotherham removed a link to an issue Mar 5, 2025
scss @import deprecation - migrate to sass module system / @use #701
Closed
@colinrotherham colinrotherham linked an issue Mar 5, 2025 that may be closed by this pull request
EPIC: Explore rebuilding NHS.UK frontend directly from GOV #952
Open
@colinrotherham colinrotherham removed a link to an issue Mar 5, 2025
EPIC: Explore rebuilding NHS.UK frontend directly from GOV #952
Open
@colinrotherham colinrotherham force-pushed the grid-updates branch 2 times, most recently from 345ade6 to 6ea31b6 Compare March 12, 2025 19:23
@colinrotherham colinrotherham changed the base branch from main to sass-deprecations May 7, 2025 19:20
@colinrotherham colinrotherham force-pushed the sass-deprecations branch 9 times, most recently from f14aa0b to 22f1c23 Compare May 9, 2025 16:07
Base automatically changed from sass-deprecations to main May 9, 2025 16:16
@colinrotherham colinrotherham changed the title [SPIKE] Update to simplified grid layout from GOV.UK Frontend Add tablet specific grid column widths May 12, 2025
@colinrotherham colinrotherham linked an issue May 12, 2025 that may be closed by this pull request
REQ: Utility classes scoped to breakpoints #1153
Open
@colinrotherham colinrotherham marked this pull request as ready for review May 12, 2025 19:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REQ: Utility classes scoped to breakpoints
1 participant
@colinrotherham