Stop reporting test coverage locally #1266
Conversation
Outputting the test code coverage table at the end of each test run makes it harder to spot which tests actually failed, as you have to scroll up each time. Our test coverage is also pretty bad right now, so the table is full of red, which shows that it’s not really working as a nudge to contributors. Suggest we remove it for now, work on improving the test coverage separately, and maybe consider a separate tool in future which could check on each pull request whether test coverage has at least not gone down?
frankieroberto
requested review from
colinrotherham,
paulrobertlloyd and
edwardhorsford
|
Does this URL load for you too (when signing in with GitHub)? Clearly it's not being collected properly but I would like to see the data gathered via GitHub Actions. It's great to check that URL over time and slowly see the numbers going up There must be a way to remove the "Quality Gate passed" 0% spam though |
404 for me. |
|
@colinrotherham ah, it works after authorising it against GitHub. But the report is broken and showing 0% for everything:
Feels like a good reason for disabling it for now? We could re-examine how best to report code coverage later? |
|
Sorry yeah, that's what I meant by this bit 😔
I'd like to fix it one rainy day so the stats work again, but also solve your spam problem That said, it's working correctly for the moved JavaScript files in #1261 (comment) ☝️ 90.9% coverage (because I added tests for module exports) |
Co-authored-by: Colin Rotherham <work@colinr.com>
|
@colinrotherham ok updated the PR and description so that this only stops the report from happening when running the tests locally, but keeps the reports when reporting the tests to Sonar. |
…uk/nhsuk-frontend into stop-reporting-test-coverage
frankieroberto
changed the title
|
Outputting the test code coverage table at the end of each test run makes it harder to spot which tests actually failed, as you have to scroll up each time.
This stops the test coverage being reported locally when running
npm test, but continues to report it to Sonar.