Skip to content

Remove unused tabs component options #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Conversation

colinrotherham
Copy link
Contributor

Description

This PR removes unused tab component options:

  {
-   namespace = 'nhsuk-tabs',
-   responsive = true,
-   historyEnabled = true,
    scope = document
  }

These options are not customisable in GOV.UK Frontend and were reviewed as part of:

Checklist

MatMoore
MatMoore previously approved these changes May 6, 2025
Base automatically changed from modules-unused-init to main May 7, 2025 08:19
@colinrotherham colinrotherham dismissed MatMoore’s stale review May 7, 2025 08:19

The base branch was changed.

@colinrotherham colinrotherham force-pushed the modules-unused-tabs branch from 241e500 to 1f1bd35 Compare May 7, 2025 08:20
Copy link

sonarqubecloud bot commented May 7, 2025

@colinrotherham colinrotherham self-assigned this May 7, 2025
@colinrotherham colinrotherham merged commit 817d242 into main May 7, 2025
13 checks passed
@colinrotherham colinrotherham deleted the modules-unused-tabs branch May 7, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants