Review and fix inconsistent link styles #1312
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@colinrotherham the regular back links aren't underlined, as has been previously noticed but I’m not sure we know why. |
|
@frankieroberto Ah the regular back links were actually underlined just fine: It was only the back link fallback that the breadcrumb component rendered (mobile) I've pushed up the text change to Update: Sorry, thought you meant on |
colinrotherham
force-pushed
the
link-styles
branch
3 times, most recently
from
f47dfe7 to
76072a7
Compare
colinrotherham
changed the title
colinrotherham
force-pushed
the
link-styles
branch
2 times, most recently
from
64eefd8 to
3444c48
Compare
colinrotherham
force-pushed
the
link-styles
branch
from
3444c48 to
02d0848
Compare
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a few link consistency issues whilst investigating #1311
For example, the breadcrumbs component as a back link on mobile:
Before
No underline on
:hoverwith mismatched icon colourAfter
Underline on
:hoverwith matching icon colourChecklist