Skip to content

Fix header menu margin collapse issue #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ This change ensures consistency with other components, where `text` or `html` pa

This change was made in [pull request #1259: Review legacy Nunjucks params](https://github.com/nhsuk/nhsuk-frontend/pull/1259).

:wrench: **Fixes**

We've made fixes to NHS.UK frontend in the following pull requests:

- [#1313: Fix header menu margin collapse issue](https://github.com/nhsuk/nhsuk-frontend/pull/1313)

## 9.6.0 - 20 May 2025

:new: **New features**
Expand Down
4 changes: 0 additions & 4 deletions app/components/all.njk
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@
{
text: "Health A-Z",
href: "#"
},
{
text: "Abscess",
href: "#"
}
]
}) }}
Expand Down
6 changes: 3 additions & 3 deletions packages/components/back-link/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@
////

.nhsuk-back-link {
margin-top: nhsuk-spacing(3);
line-height: 1; // [5]
padding-top: nhsuk-spacing(3);
line-height: 1; // [4]

@include nhsuk-media-query($from: tablet) {
margin-top: nhsuk-spacing(4);
padding-top: nhsuk-spacing(4);
}
}

Expand Down
4 changes: 2 additions & 2 deletions packages/components/breadcrumb/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@
////

.nhsuk-breadcrumb {
margin-top: nhsuk-spacing(3);
padding-top: nhsuk-spacing(3);
@include nhsuk-print-hide; // [1]

@include nhsuk-media-query($from: tablet) {
margin-top: nhsuk-spacing(4);
padding-top: nhsuk-spacing(4);
}
}

Expand Down