Skip to content

Ensure focused search input in header renders consistently across breakpoints #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 27, 2025
Merged

Ensure focused search input in header renders consistently across breakpoints #1317

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
258d063
Ensure focused search input in header renders consistently across bre…
paulrobertlloyd May 22, 2025
0982577
Update visual regression tests for header search input
paulrobertlloyd May 22, 2025
944fad0
Add visual regression tests for focused header search input
paulrobertlloyd May 22, 2025
95681cc
Adjust magnifying glass optical alignment
colinrotherham May 27, 2025
0c4e9e7
Prefer input defaults where possible
colinrotherham May 27, 2025
d1ce5d7
Remove header search cancel button (WebKit, Blink, IE)
colinrotherham May 27, 2025
113b990
Fix non-rounded account outline in older Safari
colinrotherham May 27, 2025
7ba9edc
Use higher contrast top border on white navigation
colinrotherham May 27, 2025
6589c0b
Update reference images
colinrotherham May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/components/header/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,12 @@ $_header-item-padding: 12px;
.nhsuk-header__search-input.nhsuk-input {
border-color: transparent;
border-radius: $nhsuk-border-radius 0 0 $nhsuk-border-radius;
font-size: $nhsuk-base-font-size;
height: 40px;
margin-right: -$nhsuk-border-width-form-element;
padding: 0 $_header-item-padding;
padding-right: $_header-item-padding;
padding-left: $_header-item-padding - $nhsuk-border-width-form-element;
Comment on lines +208 to +209
Copy link
Contributor

@colinrotherham colinrotherham May 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. ✅ Right padding was good
    We've already used -2px margin to hide the 2px transparent border

  2. ❌ Left padding appeared 2px too wide (14px not 12px)
    For comparison see screenshot in comment above

width: 100%;
@include nhsuk-font-size(16);

&:focus {
z-index: 10;
Expand All @@ -198,6 +199,10 @@ $_header-item-padding: 12px;
color: $color_nhsuk-grey-1;
opacity: 1; // Fixes low contrast of placeholder text in firefox
}

@include nhsuk-media-query($until: tablet) {
font-size: inherit;
}
}

.nhsuk-header__search-submit {
Expand Down