-
Notifications
You must be signed in to change notification settings - Fork 28
Updates to design system examples august25 WIP #2287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@colinrotherham it looks like I've done something wrong on the hint text page with the checkbox example at the top of the page. It's no longer displaying. Would you mind taking a look when you have a mo, please? In fact, it looks like I've knocked out a couple of examples on that page when I changed the content in the question. It used to say:
And we've been advised to make it:
|
99bd518
to
fbf4134
Compare
All fixed again @sarawilcox There was a little typo and I've fixed the 404 pages for component examples |
@sarawilcox I noticed the reverse breadcrumb content had changed 👀 We've released reverse back links and action links since too so I've updated their content to match That alright? |
Thanks @colinrotherham . I'll come back to this next week. |
{{ input({ | ||
label: { | ||
html: '<span class="nhsuk-u-visually-hidden">Building and street line 2 of 2</span>' | ||
text: "Address line 2 (optional)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My personal view is that this visible label isn't necessary - hence prefer the hidden version. I note the new version matches GOV.UK though so presumably they decided to stop hiding it too.
Hi @colinrotherham , I've made some minor content tweaks to shorten and align the content across the various reverse examples. |
a768d1b
to
eb34f60
Compare
Thanks @sarawilcox I've fixed the conflict too We had a few Nunjucks examples/patterns that weren't following our usual rules so I've pushed up some fixes E.g. Preferring double quotes, moving |
9ad6aaa
to
6aa32cc
Compare
6aa32cc
to
95fa4cd
Compare
…es and spellcheck attribute
95fa4cd
to
d0b12df
Compare
|
Description
We've identified a number of places where our components are inconsistent, look too much like GOV, aren't up to date with latest tested practice, or have clinical content that has been superceded.
I've updated the content in a number of components.
LATEST: INCOMPLETE
Related issue
#2163
Checklist
package.json
(using SEMVER)