Skip to content

Make simple search cap-insensitive by default #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
andrew-morris opened this issue Feb 16, 2020 · 2 comments
Open

Make simple search cap-insensitive by default #9

andrew-morris opened this issue Feb 16, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@andrew-morris
Copy link

andrew-morris commented Feb 16, 2020 •
edited
Loading

Right now the search functionality is cap-sensitive. This makes sense when a user is providing a regex, but for simple/quick search, it makes more sense to make search terms cap-insensitive
@nicksherron nicksherron added enhancement New feature or request good first issue Good for newcomers labels Feb 16, 2020
nicksherron added a commit that referenced this issue Feb 19, 2020
@nicksherron
internal/db: #9 add case insensitive search
eeb43df
@nicksherron
Copy link
Owner

Good idea, keep em coming! Just pushed this in eeb43df.

@nicksherron nicksherron reopened this Feb 19, 2020
nicksherron added a commit that referenced this issue Feb 19, 2020
@nicksherron
Revert "internal/db: #9 add case insensitive search"
276abf3 
This reverts commit eeb43df. While this change did successfully allow case insensitive searching, it also made regex matching of upper case letters not possible such as '^[A-Z]+$'.
This would have defeated the purpose of having regex in the first place so only an implementation of case insensitive searching that doesn't sacrifice regex functionality should be added.
@nicksherron
Copy link
Owner

I had to revert the changes because regex wouldn't work with the way it was implemented. Still open to doing this but not sure it's possible without effecting regex.

@nicksherron nicksherron removed the good first issue Good for newcomers label Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrew-morris @nicksherron