Merge pull request #256 from mtranggit/improve-accessibility-with-element-focus

nicolasbeauvais · web-flow · commit adf4c7d0d73b · 2020-11-25T11:52:15.000+01:00
Improve accessibility with element focus
diff --git a/src/share-network.js b/src/share-network.js
@@ -182,6 +182,9 @@ export default {
 
     return createElement(this.tag, {
       class: 'share-network-' + this.key,
+      attrs: {
+        href: '#'
+      },
       on: {
         click: () => this[this.rawLink.substring(0, 4) === 'http' ? 'share' : 'touch']()
       }
diff --git a/types/index.d.ts b/types/index.d.ts
@@ -17,6 +17,6 @@ export interface PluginOptions {
   networks: Record<string, string>
 }
 
-type VueSocialSharing = PluginObject<PluginOptions>
+declare const VueSocialSharing: PluginObject<PluginOptions>
 
 export default VueSocialSharing

Original file line number	Diff line number	Diff line change
`@@ -182,6 +182,9 @@ export default {`
`182`	`182`
`183`	`183`	`return createElement(this.tag, {`
`184`	`184`	`class: 'share-network-' + this.key,`
	`185`	`+ attrs: {`
	`186`	`+ href: '#'`
	`187`	`+ },`
`185`	`188`	`on: {`
`186`	`189`	`click: () => this[this.rawLink.substring(0, 4) === 'http' ? 'share' : 'touch']()`
`187`	`190`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,6 @@ export interface PluginOptions {`
`17`	`17`	`networks: Record<string, string>`
`18`	`18`	`}`
`19`	`19`
`20`		`-type VueSocialSharing = PluginObject<PluginOptions>`
	`20`	`+declare const VueSocialSharing: PluginObject<PluginOptions>`
`21`	`21`
`22`	`22`	`export default VueSocialSharing`