feat: fix validation not returning errors

Author: Niel de Wet

src/HttpClientSettings/Extensions/ServiceCollectionExtensions.cs

@@ -10,17 +10,28 @@ public static IServiceCollection AddHttpClientSettings(this IServiceCollection s
         {
             var section = configuration.GetRequiredSection(Constants.AppSettings.SectionName);
 
-            services.Configure<HttpClientAppSettings>(section)
-                .PostConfigure<HttpClientAppSettings>(config =>
+            services.AddOptions<HttpClientAppSettings>()
+                .Bind(section)
+                .Validate(httpClientAppSettings =>
                 {
-                    if (validateSettings)
-                    {
-                        var validator = new HttpClientAppSettingsValidator(config);
-                        validator.Validate();
-                    }
+                    if (validateSettings) ValidateHttpClientAppSettings(httpClientAppSettings);
+
+                    return true;
                 });
 
             return services;
         }
+
+        internal static void ValidateHttpClientAppSettings(HttpClientAppSettings httpClientAppSettings)
+        {
+            var validator = new HttpClientAppSettingsValidator(httpClientAppSettings);
+
+            var validationResponse = validator.Validate();
+
+            if (!validationResponse.IsSuccess)
+            {
+                throw new InvalidAppSettingsException(validationResponse.Errors);
+            }
+        }
     }
 }

test/HttpClientSettings.Tests/Extensions/ServiceCollectionExtensionsTests.cs

@@ -5,6 +5,8 @@ namespace HttpClientSettings.Tests.Extensions;
 
 public class ServiceCollectionExtensionsTests
 {
+    private readonly HttpClientAppSettings _settings = new();
+
     [Fact]
     public void AddHttpClientSettings_ShouldAddSettingsToConfig()
     {
@@ -15,4 +17,17 @@ public void AddHttpClientSettings_ShouldAddSettingsToConfig()
 
         services.Received().Configure<HttpClientAppSettings>(config);
     }
+
+    [Fact]
+    public void ValidateHttpClientAppSettings_GivenInvalidAppSettings_ShouldThrowException()
+    {
+        var clients = Builder<HttpClientSetting>.CreateListOfSize(1)
+             .All()
+             .With(x => x.Name, "")
+             .Build();
+
+        _settings.LoadClientsForUnitTesting(clients);
+
+        Assert.Throws<InvalidAppSettingsException>(() => ServiceCollectionExtensions.ValidateHttpClientAppSettings(_settings));
+    }
 }