Skip to content

Commit 590332a

Browse files
authored
Merge pull request #544 from nimblehq/feature/543-add-default-spacing-dimensions
[#543] Add default spacing definition in app dimensions
2 parents ce05d6b + 06dc8f5 commit 590332a

File tree

4 files changed

+19
-5
lines changed

4 files changed

+19
-5
lines changed

sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/screens/home/Item.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,13 @@ fun Item(
3333
Row {
3434
Text(
3535
modifier = Modifier
36-
.padding(dimensions.spacingNormal)
36+
.padding(dimensions.spacingMedium)
3737
.weight(1f),
3838
text = uiModel.id
3939
)
4040
Text(
4141
modifier = Modifier
42-
.padding(dimensions.spacingNormal)
42+
.padding(dimensions.spacingMedium)
4343
.weight(2f),
4444
text = uiModel.username
4545
)

sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/theme/AppDimensions.kt

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,14 @@ import androidx.compose.ui.unit.dp
55

66
class AppDimensions {
77
// Custom dimensions here
8-
val spacingNormal = 16.dp
8+
val spacing2XSmall = 4.dp
9+
val spacingXSmall = 8.dp
10+
val spacingSmall = 12.dp
11+
val spacingMedium = 16.dp
12+
val spacingLarge = 20.dp
13+
val spacingXLarge = 24.dp
14+
val spacing2XLarge = 28.dp
15+
val spacing3XLarge = 32.dp
916
}
1017

1118
internal val LocalAppDimensions = staticCompositionLocalOf { AppDimensions() }

template-compose/app/src/main/java/co/nimblehq/template/compose/ui/screens/home/HomeScreen.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ private fun HomeScreenContent(
5151
textAlign = TextAlign.Center,
5252
modifier = Modifier
5353
.fillMaxWidth()
54-
.padding(all = dimensions.spacingNormal)
54+
.padding(all = dimensions.spacingMedium)
5555
)
5656
}
5757
Timber.d("Result : $uiModels")

template-compose/app/src/main/java/co/nimblehq/template/compose/ui/theme/AppDimensions.kt

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,14 @@ import androidx.compose.ui.unit.dp
55

66
class AppDimensions {
77
// Custom dimensions here
8-
val spacingNormal = 16.dp
8+
val spacing2XSmall = 4.dp
9+
val spacingXSmall = 8.dp
10+
val spacingSmall = 12.dp
11+
val spacingMedium = 16.dp
12+
val spacingLarge = 20.dp
13+
val spacingXLarge = 24.dp
14+
val spacing2XLarge = 28.dp
15+
val spacing3XLarge = 32.dp
916
}
1017

1118
internal val LocalAppDimensions = staticCompositionLocalOf { AppDimensions() }

0 commit comments

Comments
 (0)