[#423] Remove build warnings when generating new project

ryan-conway · ryan-conway · commit e7c1330893f4 · 2023-08-22T14:20:27.000+07:00
diff --git a/template-compose/app/build.gradle.kts b/template-compose/app/build.gradle.kts
@@ -19,6 +19,8 @@ val getVersionCode: () -> Int = {
 }
 
 android {
+    namespace = "co.nimblehq.template.compose"
+
     signingConfigs {
         create(BuildType.RELEASE) {
             // Remember to edit signing.properties to have the correct info for release build.
diff --git a/template-compose/app/src/debug/AndroidManifest.xml b/template-compose/app/src/debug/AndroidManifest.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="co.nimblehq.template.compose">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
     <!--For Chucker in debug build only-->
     <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
diff --git a/template-compose/app/src/main/AndroidManifest.xml b/template-compose/app/src/main/AndroidManifest.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="co.nimblehq.template.compose">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
     <uses-permission android:name="android.permission.INTERNET" />
 
diff --git a/template-compose/data/build.gradle.kts b/template-compose/data/build.gradle.kts
@@ -6,6 +6,7 @@ plugins {
 }
 
 android {
+    namespace = "co.nimblehq.template.compose.data"
     compileSdk = Versions.ANDROID_COMPILE_SDK_VERSION
     defaultConfig {
         minSdk = Versions.ANDROID_MIN_SDK_VERSION
@@ -36,8 +37,8 @@ android {
         jvmTarget = JavaVersion.VERSION_11.toString()
     }
 
-    lintOptions {
-        isCheckDependencies = true
+    lint {
+        checkDependencies = true
         xmlReport = true
         xmlOutput = file("build/reports/lint/lint-result.xml")
     }
diff --git a/template-compose/data/src/main/AndroidManifest.xml b/template-compose/data/src/main/AndroidManifest.xml
@@ -1,2 +1,2 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest package="co.nimblehq.template.compose.data" />
+<manifest />
diff --git a/template-compose/domain/src/main/java/co/nimblehq/template/compose/domain/repository/AppPreferencesRepository.kt b/template-compose/domain/src/main/java/co/nimblehq/template/compose/domain/repository/AppPreferencesRepository.kt
@@ -6,5 +6,5 @@ interface AppPreferencesRepository {
 
     fun getAppPreference(): Flow<Boolean>
 
-    suspend fun updateAppPreference(appPreferencesValue: Boolean)
+    suspend fun updateAppPreference(appPreferenceValue: Boolean)
 }
diff --git a/template-xml/app/build.gradle.kts b/template-xml/app/build.gradle.kts
@@ -13,6 +13,8 @@ plugins {
 val keystoreProperties = rootDir.loadGradleProperties("signing.properties")
 
 android {
+    namespace = "co.nimblehq.template.xml"
+
     signingConfigs {
         create(BuildType.RELEASE) {
             // Remember to edit signing.properties to have the correct info for release build.
diff --git a/template-xml/app/src/debug/AndroidManifest.xml b/template-xml/app/src/debug/AndroidManifest.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="co.nimblehq.template.xml">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
     <!--For Chucker in debug build only-->
     <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
diff --git a/template-xml/app/src/main/AndroidManifest.xml b/template-xml/app/src/main/AndroidManifest.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="co.nimblehq.template.xml">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
     <uses-permission android:name="android.permission.INTERNET" />
 
diff --git a/template-xml/data/build.gradle.kts b/template-xml/data/build.gradle.kts
@@ -5,6 +5,7 @@ plugins {
 }
 
 android {
+    namespace = "co.nimblehq.template.xml.data"
     compileSdk = Versions.ANDROID_COMPILE_SDK_VERSION
     defaultConfig {
         minSdk = Versions.ANDROID_MIN_SDK_VERSION
diff --git a/template-xml/data/src/main/AndroidManifest.xml b/template-xml/data/src/main/AndroidManifest.xml
@@ -1,2 +1,2 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest package="co.nimblehq.template.xml.data" />
+<manifest />

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,8 @@ val getVersionCode: () -> Int = {`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`android {`
	`22`	`+ namespace = "co.nimblehq.template.compose"`
	`23`	`+`
`22`	`24`	`signingConfigs {`
`23`	`25`	`create(BuildType.RELEASE) {`
`24`	`26`	`// Remember to edit signing.properties to have the correct info for release build.`
Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@ plugins {`
`6`	`6`	`}`
`7`	`7`
`8`	`8`	`android {`
	`9`	`+ namespace = "co.nimblehq.template.compose.data"`
`9`	`10`	`compileSdk = Versions.ANDROID_COMPILE_SDK_VERSION`
`10`	`11`	`defaultConfig {`
`11`	`12`	`minSdk = Versions.ANDROID_MIN_SDK_VERSION`
`@@ -36,8 +37,8 @@ android {`
`36`	`37`	`jvmTarget = JavaVersion.VERSION_11.toString()`
`37`	`38`	`}`
`38`	`39`
`39`		`- lintOptions {`
`40`		`- isCheckDependencies = true`
	`40`	`+ lint {`
	`41`	`+ checkDependencies = true`
`41`	`42`	`xmlReport = true`
`42`	`43`	`xmlOutput = file("build/reports/lint/lint-result.xml")`
`43`	`44`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`<?xml version="1.0" encoding="utf-8"?>`
`2`		`-<manifest package="co.nimblehq.template.compose.data" />`
	`2`	`+<manifest />`
Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,5 @@ interface AppPreferencesRepository {`
`6`	`6`
`7`	`7`	`fun getAppPreference(): Flow<Boolean>`
`8`	`8`
`9`		`- suspend fun updateAppPreference(appPreferencesValue: Boolean)`
	`9`	`+ suspend fun updateAppPreference(appPreferenceValue: Boolean)`
`10`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ plugins {`
`5`	`5`	`}`
`6`	`6`
`7`	`7`	`android {`
	`8`	`+ namespace = "co.nimblehq.template.xml.data"`
`8`	`9`	`compileSdk = Versions.ANDROID_COMPILE_SDK_VERSION`
`9`	`10`	`defaultConfig {`
`10`	`11`	`minSdk = Versions.ANDROID_MIN_SDK_VERSION`