Skip to content

Update navigation library and refactor template to expose event callback to navigate #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kaungkhantsoe opened this issue Mar 11, 2025 · 0 comments
Open

Update navigation library and refactor template to expose event callback to navigate #610

kaungkhantsoe opened this issue Mar 11, 2025 · 0 comments
Assignees
@kaungkhantsoe
Labels
priority : normal type : chore

Comments

@kaungkhantsoe
Copy link
Contributor

Why

Our template does not follow Google recommended Unidirection Data Flow

  • We need to refactor it to follow the compose's Unidirection Data Flow as we do in many of our client projects
  • To do so, we will refactor the whole project to navigate through event callbacks and remove navigator from the Screen level and ViewModel level
  • We will also apply some useful custom extensions from our client's project, like NavController.navigate

Who Benefits?

Developers
kaungkhantsoe added a commit that referenced this issue Mar 11, 2025
@kaungkhantsoe
[#610] [Part 1] Update navigation library and refactor to follow unid…
8f23608 
…irectional data flow for sample compose
@kaungkhantsoe kaungkhantsoe mentioned this issue Mar 11, 2025
Open
2 tasks
kaungkhantsoe added a commit that referenced this issue Mar 11, 2025
@kaungkhantsoe
[#610] [Part 1] Update navigation library and refactor to follow unid…
d220269 
…irectional data flow for sample compose
kaungkhantsoe added a commit that referenced this issue May 2, 2025
@kaungkhantsoe
[#610] [Part 2] Update navigation library and refactor to follow unid…
5f0d06b 
…irectional data flow for template compose
@kaungkhantsoe kaungkhantsoe mentioned this issue May 2, 2025
Open
2 tasks
kaungkhantsoe added a commit that referenced this issue May 2, 2025
@kaungkhantsoe
[#610] [Part 1] Update navigation library and refactor to follow unid…
b3efc02 
…irectional data flow for sample compose
kaungkhantsoe added a commit that referenced this issue May 2, 2025
@kaungkhantsoe
[#610] [Part 2] Update navigation library and refactor to follow unid…
937dc67 
…irectional data flow for template compose
kaungkhantsoe added a commit that referenced this issue May 2, 2025
@kaungkhantsoe
[#610] [Part 1] Update navigation library and refactor to follow unid…
b651f17 
…irectional data flow for sample compose
kaungkhantsoe added a commit that referenced this issue May 2, 2025
@kaungkhantsoe
[#610] [Part 2] Update navigation library and refactor to follow unid…
3811dfe 
…irectional data flow for template compose
@kaungkhantsoe kaungkhantsoe self-assigned this May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaungkhantsoe kaungkhantsoe

Labels
priority : normal type : chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kaungkhantsoe