[CBTL-2670] Add additional business group ID

[hoangmirs]

What happened 👀

• Add SECONDARY_BUSINESS_GROUP_ID to support download assets from the secondary exchange. In our case, CBTL would like to use the common-module from GT
• Update version for all workflows to use the newest one

Insight 📝

• Published the new change to https://github.com/nimblehq/mulesoft-actions/releases/tag/v1.23.0
• Change jfc-global-actions: https://github.com/Jollibee-Foods-Corporation/jfc-global-actions/pull/29
• Update CBTL repositories to

Proof Of Work 📹

N/A

[andyduong1920]

A small comment, also can we find some other name for SECONDARY_BUSINESS_GROUP_ID @hoangmirs - how about UPSTREAM_BUSINESS_GROUP_ID 🤔

[andyduong1920]

Hi @hoangmirs can you explain a bit on this idea as we didn't consume the SECONDARY_BUSINESS_GROUP_ID in this workflow, why do we need to add it here? 🤔

Or you are missing it in uses: nimblehq/mulesoft-actions/deploy_cloudhub_1_0@v1.23.0 step?

[hoangmirs]

@andyduong1920 This enables us to define the repositories here for the app to download.

So, from my understanding, whenever we build the app (in test or deploy workflows), we will need to add it so that the app can have access to the correct repository to download the assets (documentation or modules).
For the name, SECONDARY_BUSINESS_GROUP_ID I chose it as this is not the main business group ID of the app, but another one that the app need to fetch the modules, in this case, the GT one. Same for GT app, later we might need to download from other services (maybe from JFC), so I don't think we should name it as UPSTREAM_BUSINESS_GROUP_ID.
For the naming, can we name it as ADDITIONAL_BUSINESS_GROUP_ID?

[andyduong1920]

@hoangmirs btw, Instead of putthing this new configuration, can you use the GT's BUSINESS_GROUP_ID directly in the CBTL's codebase -- because the BUSINESS_GROUP_ID isn't a sensitive information at all 🤔

[hoangmirs]

@hoangmirs btw, Instead of putthing this new configuration, can you use the GT's BUSINESS_GROUP_ID directly in the CBTL's codebase -- because the BUSINESS_GROUP_ID isn't a sensitive information at all 🤔

Is it ok to put it as hard-coded? I also want to to that so that we don't need to pass it through a few steps like the current one 🤔

[andyduong1920]

@hoangmirs btw, Instead of putthing this new configuration, can you use the GT's BUSINESS_GROUP_ID directly in the CBTL's codebase -- because the BUSINESS_GROUP_ID isn't sensitive information at all 🤔

Is it ok to put it as hard-coded? I also want to to that so that we don't need to pass it through a few steps like the current one 🤔

yes @hoangmirs as that is not sensitive information - and we have that in the app, for example, you can check the codebase like