Skip to content

add kwargs to _warnings.py #3483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

miltoncamacho
Copy link

Changes proposed in this pull request

add kwargs to the fmriprep _warnings.py script to handle new version of matplotlib warnings

closes #3478

Copy link

welcome bot commented Jul 15, 2025

Thanks for opening this pull request! It looks like this is your first time contributing to fMRIPrep. 😄
We invite you to list yourself as an fMRIPrep contributor. To learn more about what that entails and how we credit our contributors, please check out the contributing guidelines. If your name is not already on the list, please insert it, in alphabetical order, into the CONTRIBUTORS.md file.
Of course, if you want to opt-out this time there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed.

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.49%. Comparing base (adf472c) to head (09da4e8).

Files with missing lines Patch % Lines
fmriprep/_warnings.py 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3483      +/-   ##
==========================================
- Coverage   73.52%   73.49%   -0.04%     
==========================================
  Files          60       60              
  Lines        4570     4572       +2     
  Branches      583      584       +1     
==========================================
  Hits         3360     3360              
- Misses       1083     1084       +1     
- Partials      127      128       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Ultimately, we will want to revisit (or altogether remove) our _warnings module, as we are now losing functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recurring "unexpected keyword argument 'skip_file_prefixes'" Error
2 participants