upgrade @nish1896/eslint-config to 1.0.4 (#7)

Author: nishkohli96

apps/express-server/.eslintrc.js

@@ -1,3 +1,3 @@
 module.exports = {
   extends: ['@nish1896']
-}
+};

apps/express-server/src/app-constants/env_vars.ts

@@ -5,6 +5,4 @@
 
 const env = process.env;
 
-export const ENV_VARS = Object.freeze({
-  port: env.port ?? 5000,
-});
+export const ENV_VARS = Object.freeze({ port: env.port ?? 5000 });

apps/express-server/src/app.ts

@@ -15,7 +15,7 @@ app.get('/', (_: Request, response: Response) => {
   response.status(200).send('Api is up & running!!!');
 });
 
-app.use(`/api/auth`, Routes.authRouter);
+app.use('/api/auth', Routes.authRouter);
 
 /* 404 Handler - To be written at last */
 app.get('*', (req: Request, response: Response) => {

apps/express-server/src/middleware/guard.ts

@@ -4,10 +4,10 @@ import { winstonLogger } from './winston-logger';
 export function validateAuthHeader(
   req: Request<object, object, object, object>,
   res: Response,
-  next: NextFunction
+  next: NextFunction,
 ) {
   /* Check presence of jwt and refresh-token */
-  let token: string | undefined = req.cookies?.['jwt'];
+  const token: string | undefined = req.cookies?.jwt;
 
   if (!token) {
     const errorMsg = 'Unauthorized request';
@@ -22,7 +22,7 @@ export function validateAuthHeader(
 export function authenticateAdmin(
   _: Request<object, object, object, object>,
   res: Response,
-  next: NextFunction
+  next: NextFunction,
 ) {
   if (res.locals?.user?.role === 'Admin') {
     next();
@@ -37,7 +37,7 @@ export function checkTokenMismatchInReqParams(
   /* eslint-disable-next-line @typescript-eslint/no-explicit-any */
   req: Request<any, object, object, object>,
   res: Response,
-  next: NextFunction
+  next: NextFunction,
 ) {
   if (res.locals?.user?._id !== req.params.id) {
     return res.status(406).send('Token Mismatch').end();

apps/express-server/src/middleware/request-logger.ts

@@ -4,7 +4,7 @@ import { winstonLogger } from './winston-logger';
 export function requestLogger(
   request: Request,
   response: Response,
-  next: NextFunction
+  next: NextFunction,
 ) {
   winstonLogger.info(`${request.method} ${request.url}`);
   response.on('finish', () => {

apps/express-server/src/middleware/winston-logger.ts

@@ -11,19 +11,19 @@ const customLevels = {
     warn: 1,
     info: 2,
     http: 3,
-    success: 4
+    success: 4,
   },
   colors: {
     error: 'bold red blackBG',
     warn: 'italic yellow',
     info: 'blue',
     http: 'magenta',
-    success: 'green'
+    success: 'green',
   },
 };
 
 const myFormat = printf(
-  ({ level, message, timestamp }) => `[ ${level} ]:: ${timestamp} - ${message}`
+  ({ level, message, timestamp }) => `[ ${level} ]:: ${timestamp} - ${message}`,
 );
 
 /**
@@ -46,7 +46,7 @@ const winstonLogger = createLogger({
 
     /* Aligns in a tabular format */
     // format.align(),
-    myFormat
+    myFormat,
   ),
   //   defaultMeta: { service: 'log-service' },
   transports: [
@@ -71,7 +71,7 @@ addColors(customLevels.colors);
 
 if (process.env.NODE_ENV !== 'production') {
   winstonLogger.add(
-    new transports.Console({ format: format.colorize({ all: true }) })
+    new transports.Console({ format: format.colorize({ all: true }) }),
   );
 }
 

apps/express-server/src/routes/auth/controller.ts

@@ -6,21 +6,21 @@ const authRouter = Router();
 
 authRouter.get(
   '/test',
-  async function printHello(_, res: Response) {
+  function printHello(_, res: Response) {
     return res.status(200).send('Hello World !!').end();
-  }
+  },
 );
 
 /* Login user */
 authRouter.post(
   '/login',
-  async function loginUser(
+  function loginUser(
     req: Request<object, object, AuthTypes.UserLoginBody>,
-    res: Response
+    res: Response,
   ) {
     const { email, password } = req.body;
-    return await authService.loginUser(res, email, password);
-  }
+    return authService.loginUser(res, email, password);
+  },
 );
 
 export { authRouter };

apps/express-server/src/routes/auth/service.ts

@@ -1,12 +1,12 @@
 import { Response } from 'express';
 
 class AuthService {
-  async loginUser(res: Response, email: string, password: string) {
+  loginUser(res: Response, email: string, password: string) {
     try {
-      res.send({
+      res.status(200).send({
         email,
         password,
-      });
+      }).end();
     } catch (err) {
       res.status(500).send('Internal Server Error');
     }

apps/express-server/src/routes/auth/types.ts

@@ -1,4 +1,4 @@
 export interface UserLoginBody {
   email: string;
   password: string;
-}
+}

apps/frontend/.eslintrc.js

@@ -1,3 +1,6 @@
-// module.exports = {
-// 	extends: ['@nish1896']
-// }
+module.exports = {
+  extends: ['@nish1896'],
+  rules: {
+    '@typescript-eslint/no-non-null-assertion': 'off',
+  }
+};