chore: move to ifrit
#6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make things easier, I decided to move the PE writer into another subcrate called `ifrit` which will mature the PE writer and maybe merge it back in `faerie` in the future.
We reinforce our safety by making `AttributeCertificate::from_bytes` faillible, indeed the length calculus can fail if the platform integers are wrong, this increases portability. We control better our alignment by having a proper equality function modulo alignments. This fixes all the remaining tests. Signed-off-by: raito <federez-infra@lahfa.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make things easier, I decided to move the PE writer into another subcrate called
ifritwhich will mature the PE writer and maybe merge it back infaeriein the future.This tests things with the latest PR in Goblin: m4b/goblin#389.
All tests are passing locally.