-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
zsh: add options zsh.history.{appendInc,appendIncTime} #7333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
6a6086d
to
448ef7d
Compare
Makes it easier to keep the overview as new options are added.
This adds the ZSH options `INC_APPEND_HISTORY` and `INC_APPEND_HISTORY_TIME`.
Rebased. Are we good to go now, @teto @khaneliman? |
Just not a fan of this option set in the current form. It is too verbose and maintenance heavy to keep adding a new option for each possible Seems more like we should deprecate these options and encourage usage of that |
I agree that this is verbose. I wasn't aware of Personally, my favorite form would be something like: setOptions =
lib.mapAttrsToList (name: enabled: if enabled then name else "NO_${name}") {
APPEND_HISTORY = false;
EXTENDED_HISTORY = true;
HIST_EXPIRE_DUPS_FIRST = false;
HIST_FCNTL_LOCK = true;
HIST_FIND_NO_DUPS = false;
HIST_IGNORE_ALL_DUPS = false;
HIST_IGNORE_DUPS = true;
HIST_IGNORE_SPACE = true;
HIST_SAVE_NO_DUPS = false;
INC_APPEND_HISTORY = true;
SHARE_HISTORY = false;
}; This helps to keep alphabetical sorting. But the current setOptions is also fine. |
Seems to be the new preferable way [0]. [0] nix-community/home-manager#7333 (comment)
Seems to be the new preferable way [0]. [0] nix-community/home-manager#7333 (comment)
Description
This adds the ZSH options
INC_APPEND_HISTORY
andINC_APPEND_HISTORY_TIME
.Checklist
Change is backwards compatible.
Code formatted with
nix fmt
ornix-shell -p treefmt nixfmt-rfc-style keep-sorted --run treefmt
.Code tested through
nix-shell --pure tests -A run.all
or
nix build --reference-lock-file flake.lock ./tests#test-all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC