iamb: use macos configuration directory when on darwin #7483
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heywoodlh
changed the title
heywoodlh
force-pushed
the
iamb-macos-settings-support
branch
from
2d957e0 to
7c6e5d4
Compare
heywoodlh
force-pushed
the
iamb-macos-settings-support
branch
from
7c6e5d4 to
13ea0d9
Compare
khaneliman
reviewed
Jul 16, 2025
| home.packages = lib.mkIf (cfg.package != null) [ cfg.package ]; | ||
| config = | ||
| let | ||
| configFile = tomlFormat.generate "iamb-config" cfg.settings; |
There was a problem hiding this comment.
Suggested change
| configFile = tomlFormat.generate "iamb-config" cfg.settings; | |
| configFile = tomlFormat.generate "iamb-config" cfg.settings; | |
| configDir = | |
| if pkgs.stdenv.isDarwin then | |
| "Library/Application Support" | |
| else | |
| config.xdg.configHome; |
Could do this, like we do in other modules, and then simplify the config block with one file generation condition using home.file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the correct configuration directory when on MacOS for the iamb module
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt-rfc-style deadnix keep-sorted --run treefmt.Code tested through
nix-shell --pure tests -A run.allor
nix build --reference-lock-file flake.lock ./tests#test-allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@wikiker