Skip to content

Conversation

VlaDexa
Copy link
Contributor

@VlaDexa VlaDexa commented Aug 21, 2025

Description

Introduce new option for a customizable systemd targets to allow enabling
the service only in certain environments.

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.

  • Code tested through nix run .#tests -- test-all or
    nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

Copy link
Contributor

@ambroisie ambroisie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand when you would want to use this but not config.wayland.systemd.target, can you give an explanation?

@@ -60,6 +60,14 @@ let
size = "32x32";
};

systemdTargets = lib.mkOption {
type = with lib.types; listOf str;
default = [ config.wayland.systemd.target ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a defaultText.

@VlaDexa
Copy link
Contributor Author

VlaDexa commented Aug 21, 2025

I'm trying to make a hyprland setup that doesn't interfere with KDE as much as I can. Plasma doesn't need a notifications manager, because it has it's own.

Introduce new option for a customizable systemd targets to allow enabling
the service only in certain environments.
@VlaDexa VlaDexa force-pushed the dunst-systemdTargets branch from 06fee2d to 6f40307 Compare August 24, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants