systemd: make unit definitions freeform modules #7706
Draft
+82
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add types for a few of the most common attributes.
rycee
force-pushed
the
systemd-unit-freeform-module
branch
from
1cbf9fd to
282b7c7
Compare
rycee
commented
Aug 21, 2025
| unitBaseType "service" { | ||
| options.Service = { | ||
| Environment = mkOption { | ||
| type = with types; either str (listOf str); |
There was a problem hiding this comment.
It would probably be possible to support something like attrsOf primitive as a more ergonomic way to express variable assignment (similar to the sessionVariables options).
ambroisie
reviewed
Aug 22, 2025
Comment on lines
+107
to
+108
| type = with types; either str (listOf str); | ||
| apply = p: if builtins.isList p then p else [ p ]; |
There was a problem hiding this comment.
This is lib.toList (a no-op on lists), but otherwise using coercedTo str lib.toList (listOf str) removes the need for apply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is some experiments in making the systemd unit descriptions more typed by using freeform modules.
Checklist
Change is backwards compatible.
Technically no, with this change we would, for example, reject
ExecStart = 42(which is nonsense) but quite possibly also valid configurations.Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
If this PR adds an exciting new feature or contains a breaking change.
Generate a news entry. See News
Will do this if leaving draft.