controller: fix reclaimspacejob reason bug

Status.Condition[*].Reason is a required field
and it needs a camelCase string to be given.
If not given, object Update will fail.

Signed-off-by: Rakshith R <rar@redhat.com>

Author: Rakshith-R

controllers/reclaimspacejob_controller.go

@@ -51,6 +51,9 @@ const (
 
 	// failed condition type.
 	conditionFailed = "Failed"
+	// failed reason type.
+	// TODO: add more useful reason types.
+	reasonFailed = "failed"
 )
 
 // ReclaimSpaceJobReconciler reconciles a ReclaimSpaceJob object.
@@ -429,6 +432,7 @@ func setFailedCondition(
 		ObservedGeneration: observedGeneration,
 		LastTransitionTime: metav1.NewTime(time.Now()),
 		Message:            message,
+		Reason:             reasonFailed,
 	}
 	for i := range *conditions {
 		if (*conditions)[i].Type == conditionFailed {

controllers/reclaimspacejob_controller_test.go

@@ -45,7 +45,7 @@ func TestSetFailedCondition(t *testing.T) {
 						Status:             v1.ConditionTrue,
 						ObservedGeneration: 0,
 						LastTransitionTime: v1.NewTime(time.Now()),
-						Reason:             "",
+						Reason:             reasonFailed,
 						Message:            "err 1",
 					},
 				},