Skip to content

Commit db86e34

Browse files
Merge pull request #17 from openshift-cherrypick-robot/cherry-pick-16-to-release-4.10
[release-4.10] build: generate a clusterserviceversion manifest with PACKAGE_NAME
2 parents 8ea748e + ae44436 commit db86e34

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

Makefile

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,14 @@ help: ## Display this help.
8686
manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects.
8787
$(CONTROLLER_GEN) rbac:roleName=manager-role crd webhook paths="{./api/...,./cmd/...,./controllers/...,./sidecar/...}" output:crd:artifacts:config=config/crd/bases
8888

89+
# generate the <package-name>.clusterserviceversion.yaml
90+
config/manifests/bases/$(PACKAGE_NAME).clusterserviceversion.yaml: config/manifests/bases/clusterserviceversion.yaml.in
91+
sed 's/@PACKAGE_NAME@/$(PACKAGE_NAME)/g' < $^ > $@
92+
8993
.PHONY: bundle
90-
bundle: kustomize operator-sdk
94+
bundle: config/manifests/bases/$(PACKAGE_NAME).clusterserviceversion.yaml kustomize operator-sdk
9195
cd config/manager && $(KUSTOMIZE) edit set image controller=$(CONTROLLER_IMG) $(KUSTOMIZE_RBAC_PROXY)
92-
$(KUSTOMIZE) build config/default | $(OPERATOR_SDK) generate bundle --manifests --metadata --package=$(PACKAGE_NAME) $(BUNDLE_VERSION)
93-
mkdir -p ./bundle/tests/scorecard && $(KUSTOMIZE) build config/scorecard --output=./bundle/tests/scorecard/config.yaml
96+
$(KUSTOMIZE) build config/manifests | $(OPERATOR_SDK) generate bundle --manifests --metadata --package=$(PACKAGE_NAME) $(BUNDLE_VERSION)
9497

9598
.PHONY: generate
9699
generate: controller-gen ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.

config/manifests/bases/csi-addons.clusterserviceversion.yaml renamed to config/manifests/bases/clusterserviceversion.yaml.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ metadata:
44
annotations:
55
alm-examples: '[]'
66
capabilities: Basic Install
7-
name: csi-addons.v0.1.1
7+
name: @PACKAGE_NAME@.v0.1.1
88
namespace: placeholder
99
spec:
1010
apiservicedefinitions: {}

config/manifests/kustomization.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# These resources constitute the fully configured set of manifests
2+
# used to generate the 'manifests/' directory in a bundle.
3+
resources:
4+
- ../default
5+
- ../scorecard

0 commit comments

Comments
 (0)