Fix downloading embedded images (#2853)

Fixes #2852 

Authentication HTTP header was not set correctly, so images were not
downloaded. Requests were failing with 401 Unauthorized response. I
tested it for `Windows` authentication mode in source and now it is
working correctly.

## Changes

- Correctly create token for basic HTTP authorization header based on
authentication type.
- Removed `sourceWorkItem` parameter from `FixEmbededImages` method,
because it was not used.

Author: MrHinsh

src/MigrationTools.Clients.TfsObjectModel/Processors/TfsWorkItemMigrationProcessor.cs

@@ -598,7 +598,7 @@ private void ProcessHTMLFieldAttachements(WorkItemData targetWorkItem)
         {
             if (targetWorkItem != null && Options.FixHtmlAttachmentLinks)
             {
-                CommonTools.EmbededImages.FixEmbededImages(this, null, targetWorkItem);
+                CommonTools.EmbededImages.FixEmbededImages(this, targetWorkItem);
             }
         }
 

src/MigrationTools.Clients.TfsObjectModel/Processors/TfsWorkItemOverwriteProcessor.cs

@@ -1,21 +1,16 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
-using System.Linq;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Options;
 using Microsoft.TeamFoundation.WorkItemTracking.Client;
-using MigrationTools;
-using MigrationTools.Clients;
-using MigrationTools._EngineV1.Configuration;
-using MigrationTools._EngineV1.Configuration.Processing;
 using MigrationTools._EngineV1.DataContracts;
-
+using MigrationTools.Clients;
 using MigrationTools.DataContracts;
-using Microsoft.Extensions.Options;
-using MigrationTools.Tools;
-using MigrationTools.Processors.Infrastructure;
 using MigrationTools.Enrichers;
+using MigrationTools.Processors.Infrastructure;
+using MigrationTools.Tools;
 
 namespace MigrationTools.Processors
 {
@@ -69,9 +64,9 @@ protected override void InternalExecute()
                 {
                     Log.LogInformation("...Exists");
                     TfsExtensions.ToWorkItem(targetFound).Open();
-                   CommonTools.FieldMappingTool.ApplyFieldMappings(sourceWI, targetFound);
+                    CommonTools.FieldMappingTool.ApplyFieldMappings(sourceWI, targetFound);
                     CommonTools.WorkItemEmbededLink.Enrich(this, null, targetFound);
-                    CommonTools.EmbededImages.FixEmbededImages(this, sourceWI, targetFound);
+                    CommonTools.EmbededImages.FixEmbededImages(this, targetFound);
                     if (TfsExtensions.ToWorkItem(targetFound).IsDirty)
                     {
                         try
@@ -105,4 +100,4 @@ protected override void InternalExecute()
         }
 
     }
-}
+}

src/MigrationTools.Clients.TfsObjectModel/Tools/TfsEmbededImagesTool.cs

@@ -4,6 +4,7 @@
 using System.Net;
 using System.Net.Http;
 using System.Net.Http.Headers;
+using System.Text;
 using System.Text.RegularExpressions;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
@@ -12,6 +13,7 @@
 using Microsoft.TeamFoundation.WorkItemTracking.WebApi;
 using MigrationTools.DataContracts;
 using MigrationTools.Endpoints;
+using MigrationTools.Options;
 using MigrationTools.Processors.Infrastructure;
 using MigrationTools.Tools.Infrastructure;
 
@@ -24,7 +26,6 @@ public class TfsEmbededImagesTool : EmbededImagesRepairToolBase<TfsEmbededImages
         private const string TargetDummyWorkItemTitle = "***** DELETE THIS - Migration Tool Generated Dummy Work Item For TfsEmbededImagesTool *****";
 
         private Project _targetProject;
-        private TfsTeamProjectEndpointOptions _targetConfig;
 
         private readonly IDictionary<string, string> _cachedUploadedUrisBySourceValue;
 
@@ -35,16 +36,23 @@ public TfsEmbededImagesTool(IOptions<TfsEmbededImagesToolOptions> options, IServ
             _cachedUploadedUrisBySourceValue = new System.Collections.Concurrent.ConcurrentDictionary<string, string>(StringComparer.InvariantCultureIgnoreCase);
         }
 
-
-        public int FixEmbededImages(TfsProcessor processor, WorkItemData sourceWorkItem, WorkItemData targetWorkItem)
+        public int FixEmbededImages(TfsProcessor processor, WorkItemData targetWorkItem)
         {
             _processor = processor;
             _targetProject = processor.Target.WorkItems.Project.ToProject();
-            _targetConfig = processor.Target.Options;
-            FixEmbededImages(targetWorkItem, processor.Source.Options.Collection.AbsoluteUri, processor.Target.Options.Collection.AbsoluteUri, processor.Source.Options.Authentication.AccessToken);
+            string? accessToken = processor.Source.Options.Authentication.AuthenticationMode switch
+            {
+                AuthenticationMode.AccessToken => processor.Source.Options.Authentication.AccessToken,
+                AuthenticationMode.Windows => GetWindowsAuthToken(processor.Source.Options.Authentication.NetworkCredentials),
+                _ => null
+            };
+            FixEmbededImages(targetWorkItem, processor.Source.Options.Collection.AbsoluteUri, processor.Target.Options.Collection.AbsoluteUri, accessToken);
             return 0;
         }
 
+        private string GetWindowsAuthToken(NetworkCredentials cred)
+            => Convert.ToBase64String(Encoding.ASCII.GetBytes($"{cred.Domain}\\{cred.UserName}:{cred.Password}"));
+
         public void ProcessorExecutionEnd(TfsProcessor processor)
         {
             _processor = processor;
@@ -124,7 +132,7 @@ private string UploadedAndRetrieveAttachmentLinkUrl(string matchedSourceUri, str
                 {
                     if (!string.IsNullOrEmpty(sourcePersonalAccessToken))
                     {
-                        httpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Basic", Convert.ToBase64String(System.Text.Encoding.ASCII.GetBytes(string.Format("{0}:{1}", "", sourcePersonalAccessToken))));
+                        httpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Basic", sourcePersonalAccessToken);
                     }
                     var result = DownloadFile(httpClient, matchedSourceUri, fullImageFilePath);
                     if (!result.IsSuccessStatusCode)
@@ -182,7 +190,7 @@ private Microsoft.TeamFoundation.WorkItemTracking.WebApi.Models.AttachmentRefere
             }
 
             // Attaches it with dummy work item and removes it just to be able to make the image visible to all the users.
-            // VS402330: Unauthorized Read access to the attachment under the areas 
+            // VS402330: Unauthorized Read access to the attachment under the areas
             var payload = new Microsoft.VisualStudio.Services.WebApi.Patch.Json.JsonPatchDocument();
             payload.Add(new Microsoft.VisualStudio.Services.WebApi.Patch.Json.JsonPatchOperation()
             {